Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you add an overloaded function to IMARSRequest? #85

Closed
gmurt opened this issue May 28, 2020 · 1 comment
Closed

Could you add an overloaded function to IMARSRequest? #85

gmurt opened this issue May 28, 2020 · 1 comment
Assignees

Comments

@gmurt
Copy link

gmurt commented May 28, 2020

Hi Andrea,

In my project I used the following which is not compatible with the latest version.

[Context] Request: THttpRequest;

I've changed to use the new interface version but it seems I'm missing the "request.QueryFields.Value[]" property which I used previously.

I've made a modification to the interface to allow me to access query values by name...

    function GetFormParamValue(const AIndex: Integer): string; overload;
    function GetFormParamValue(const AName: string): string; overload;  <-- NEW 

....

function TMARSWebRequest.GetQueryParamValue(const AName: string): string;
begin
  Result := FWebRequest.QueryFields.Values[AName];
end;

Is there any chance you can include this in the next update?

Many thanks,
Graham

@andrea-magni andrea-magni self-assigned this May 28, 2020
andrea-magni added a commit that referenced this issue May 28, 2020
@andrea-magni
Copy link
Owner

I just pushed some changes to add the GetQueryParamValue method overload that I think you were referring to. Let me know if everything is fine and feel free to reopen this issue if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants