Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added provision for backgroind mask #107

Merged
merged 2 commits into from
Mar 23, 2017

Conversation

gauravkeshre
Copy link

There are instances when we need a mask to dim the background when the popup is being displayed.
This can be disabled with properties.

@codecov-io
Copy link

codecov-io commented Mar 17, 2017

Codecov Report

Merging #107 into master will decrease coverage by 0.49%.
The diff coverage is 60.6%.

@@            Coverage Diff            @@
##           master     #107     +/-   ##
=========================================
- Coverage   72.06%   71.57%   -0.5%     
=========================================
  Files           6        6             
  Lines         648      679     +31     
=========================================
+ Hits          467      486     +19     
- Misses        181      193     +12
Impacted Files Coverage Δ
Source/AMPopTip+Exit.m 17.5% <0%> (-0.93%)
Source/AMPopTipDefaults.h 100% <100%> (ø)
Source/AMPopTip+Entrance.m 34.14% <47.05%> (+2.8%)
Source/AMPopTip.m 84.61% <84.61%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 966052a...f353ad7. Read the comment docs.

@andreamazz andreamazz merged commit f353ad7 into andreamazz:master Mar 23, 2017
@andreamazz
Copy link
Owner

Thank you @gauravkeshre
Much appreciated 👍

@andreamazz
Copy link
Owner

Released with 1.5.0. Note that I set the default value of shouldShowMask to false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants