Correct issue postitioning tooltip on scrollviews #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tview not the real scrollview size. It is useful for example when the tip is showed in a UITableView. If we don't make the change in the code, when the tip is showed in a row which stays down in the table (high IndexPath) the tip is showed upper in the content view so wildly misplaced
|
Looks good, thank you. It might be worth to account for the x, but it might be an edge, so for now I'll merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a tooltip was positioned out of the view the library changed the position to fit the tooltip in the view taking care of the margins. That is fine but not always. In UIScrollViews and its descendants if the tip is placed with a high "y" coordinate the library changes the position in spite of being correctly placed inside de contentview.
Tips now are showed in scrollviews considering the size of the contentview not the real scrollview size.
It is useful for example when the tip is showed in a UITableView. If we don't make the change in the code, when the tip is showed in a row which stays down in the table (high IndexPath) the tip is showed upper in the content view so wildly misplaced
Hope the change is welcome.
P.S. I suppose that the change would be useful also in the "x" direction but i have not needed it.