Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SwiftUI custom views #196

Merged
merged 6 commits into from
Nov 14, 2019

Conversation

rivera-ernesto
Copy link
Contributor

New show method to allow using custom SwiftUI views embed in a UIHostingController.
Proper child controller events are triggered as well.

Includes needed changes from #195.

@andreamazz
Copy link
Owner

Hi @rivera-ernesto
Thanks, I really appreciate the contribution. Can I ask you to add a samll sample snippet in the README for the new show?

@rivera-ernesto rivera-ernesto force-pushed the support_swiftui_customviews branch from b1779dc to 66c9559 Compare November 14, 2019 13:39
@andreamazz andreamazz merged commit 44cafce into andreamazz:master Nov 14, 2019
@andreamazz
Copy link
Owner

Awesome, thanks!

@rivera-ernesto
Copy link
Contributor Author

Hi @rivera-ernesto
Thanks, I really appreciate the contribution. Can I ask you to add a samll sample snippet in the README for the new show?

Sure, will describe usage in the README.

@rivera-ernesto rivera-ernesto deleted the support_swiftui_customviews branch November 18, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants