Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix websocket conflict, update deprecated Fmt functions #206

Merged
merged 3 commits into from
Apr 21, 2022

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented Mar 30, 2022

Fixes #203 by renaming websocket.ml and websocket.mli to graphql_websocket.ml and graphql_websocket.mli

@zshipko zshipko force-pushed the fix-websocket-conflict branch from a8c3ae5 to c1cf474 Compare March 30, 2022 19:47
@zshipko
Copy link
Contributor Author

zshipko commented Mar 30, 2022

I don't think the test failure is related to these changes. But I tried adding core_kernel to the graphql-async opam file but that didn't seem to fix the issue.

Edit: Looks like Core_kernel is now deprecated so I just updated the test to use Core instead

@andreas andreas merged commit 520ccd4 into andreas:master Apr 21, 2022
@andreas
Copy link
Owner

andreas commented Apr 21, 2022

Thanks!

@zshipko zshipko mentioned this pull request May 24, 2022
kit-ty-kate pushed a commit to ocaml/opam-repository that referenced this pull request Jul 19, 2022
…d graphql-async (0.14.0)

CHANGES:

- Support `__typename` on subscriptions (andreas/ocaml-graphql-server#178)
- Handle unknown fields for subscriptions (andreas/ocaml-graphql-server#178)
- Add ocamlformat (andreas/ocaml-graphql-server#177)
- Handle missing variables as null (andreas/ocaml-graphql-server#184)
- Show default value in introspection query (andreas/ocaml-graphql-server#194)
- Support block strings in the parser (andreas/ocaml-graphql-server#198)
- Handle skip/include directives on fragment spreads (andreas/ocaml-graphql-server#200)
- Improved handling of recursive arguments and objects (andreas/ocaml-graphql-server#199)
- Fix websocket conflict (andreas/ocaml-graphql-server#206)
- Update deprecated Fmt functions (andreas/ocaml-graphql-server#206)
- Use Yojson `t` types instead of deprecated `json` type (andreas/ocaml-graphql-server#208)
- Raise minimum `rresult` version (andreas/ocaml-graphql-server#209)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Websocket conflict
2 participants