Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfaults in test 37 #33

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Fix segfaults in test 37 #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b175e69
Check maximum depth of nested continuations
karzhenkov Jan 10, 2021
b43d6b1
Reduce allowed depth of nested continuations to zero
karzhenkov Jan 10, 2021
01fbc06
Try a workaround to prevent nested continuations
karzhenkov Jan 10, 2021
9954e49
Run selected test using verbose mode
karzhenkov Jan 11, 2021
2e83b23
Adjust timeout
karzhenkov Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/cmake.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,4 +191,6 @@ jobs:
shell: bash
# Execute tests defined by the CMake configuration.
# See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail
run: ctest --output-on-failure -C $BUILD_TYPE
run: |
ctest --output-on-failure -C $BUILD_TYPE && \
ctest -V -R '^async auto reset event tests-multi-threaded$'
2 changes: 1 addition & 1 deletion test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ if(WIN32)
)
else()
# let more time for some tests
set(async_auto_reset_event_tests_TIMEOUT 60)
set(async_auto_reset_event_tests_TIMEOUT 200)
endif()

foreach(test ${tests})
Expand Down
12 changes: 12 additions & 0 deletions test/async_auto_reset_event_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,18 @@ TEST_CASE("multi-threaded")
co_await tp.schedule();
co_await event;
++value;

thread_local volatile bool nested = false;

if (nested)
{
co_await tp.schedule();
assert(!nested);
}

nested = true;
cppcoro::scoped_lambda cleanup = [] { nested = false; };

event.set();
};

Expand Down