Merge pull request #523 from andreasfertig/fixIssue522

Fixed #522: Keep the type of the `typeid` expression as written.
andreasfertig · Apr 12, 2023 · 69df61d · 69df61d
2 parents 5b64999 + 8af7b1a
commit 69df61d
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/CodeGenerator.cpp b/CodeGenerator.cpp
@@ -696,7 +696,7 @@ void CodeGenerator::InsertArg(const CXXTypeidExpr* stmt)
     mOutputFormatHelper.Append(kwTypeId);
     WrapInParens([&]() {
         if(stmt->isTypeOperand()) {
-            mOutputFormatHelper.Append(GetName(stmt->getType()));
+            mOutputFormatHelper.Append(GetName(stmt->getTypeOperand(const_cast<ASTContext&>(GetGlobalAST()))));
         } else {
             InsertArg(stmt->getExprOperand());
         }

diff --git a/tests/Issue522.cpp b/tests/Issue522.cpp
@@ -0,0 +1,3 @@
+#include <typeinfo>
+std::type_info const& tiA = typeid(int);
+std::type_info const& tiB = typeid(0);
diff --git a/tests/Issue522.expect b/tests/Issue522.expect
@@ -0,0 +1,5 @@
+#include <typeinfo>
+const std::type_info & tiA = typeid(int);
+
+const std::type_info & tiB = typeid(0);
+
diff --git a/tests/TypeIdInTemplateTest.expect b/tests/TypeIdInTemplateTest.expect
@@ -10,7 +10,7 @@ class Foo
   public: 
   inline std::basic_string<char, std::char_traits<char>, std::allocator<char> > Get()
   {
-    std::basic_string<char, std::char_traits<char>, std::allocator<char> > typeId = std::basic_string<char, std::char_traits<char>, std::allocator<char> >{typeid(const std::type_info).name()} /* NRVO variable */;
+    std::basic_string<char, std::char_traits<char>, std::allocator<char> > typeId = std::basic_string<char, std::char_traits<char>, std::allocator<char> >{typeid(T).name()} /* NRVO variable */;
     return std::basic_string<char, std::char_traits<char>, std::allocator<char> >(static_cast<std::basic_string<char, std::char_traits<char>, std::allocator<char> > &&>(typeId));
   }
 
@@ -25,7 +25,7 @@ class Foo<int>
   public: 
   inline std::basic_string<char, std::char_traits<char>, std::allocator<char> > Get()
   {
-    std::basic_string<char, std::char_traits<char>, std::allocator<char> > typeId = std::basic_string<char, std::char_traits<char>, std::allocator<char> >{typeid(const std::type_info).name()} /* NRVO variable */;
+    std::basic_string<char, std::char_traits<char>, std::allocator<char> > typeId = std::basic_string<char, std::char_traits<char>, std::allocator<char> >{typeid(int).name()} /* NRVO variable */;
     return std::basic_string<char, std::char_traits<char>, std::allocator<char> >(static_cast<std::basic_string<char, std::char_traits<char>, std::allocator<char> > &&>(typeId));
   }