Fixed #264: Wrap BinaryOperators in their according parentheses. #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This goes not only for `BinaryOperators`in fold expressions. All expressions with a `BinaryOperator` are now wrapped. While processing #264 there was another error with the `TypePrinter` regarding the lambdas `auto` parameter which is fixed by this patch as well.
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
==========================================
+ Coverage 96.37% 96.39% +0.01%
==========================================
Files 23 23
Lines 2569 2577 +8
==========================================
+ Hits 2476 2484 +8
Misses 93 93
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes not only for
BinaryOperatorsin fold expressions. Allexpressions with a
BinaryOperatorare now wrapped.While processing #264 there was another error with the
TypePrinterregarding the lambdas
autoparameter which is fixed by this patchas well.