Fixed #333: Check for valid SourceLocation of attributes.
#334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions like `operator new` and `operator delete` carry a hidden
attribute `__attribute__((visibility("default")))` which has no valid
`SourceLocation` as it is inherited from the STL. This patch adds code
to use only a valid `SourceLocation` to apply the offset to it to get
the replacement range of the `FunctionDecl`.
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
=======================================
Coverage 97.87% 97.87%
=======================================
Files 23 23
Lines 2917 2920 +3
=======================================
+ Hits 2855 2858 +3
Misses 62 62
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions like
operator newandoperator deletecarry a hiddenattribute
__attribute__((visibility("default")))which has no validSourceLocationas it is inherited from the STL. This patch adds codeto use only a valid
SourceLocationto apply the offset to it to getthe replacement range of the
FunctionDecl.