Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fava_dashboards.templates is absent from setuptools' packages configuration #18

Closed
AlphaJack opened this issue Sep 11, 2023 · 3 comments · Fixed by #19
Closed

fava_dashboards.templates is absent from setuptools' packages configuration #18

AlphaJack opened this issue Sep 11, 2023 · 3 comments · Fixed by #19

Comments

@AlphaJack
Copy link

* Getting build dependencies for wheel...
* Building wheel...
running bdist_wheel
running build
running build_py
creating build
creating build/lib
creating build/lib/fava_dashboards
copying fava_dashboards/__init__.py -> build/lib/fava_dashboards
running egg_info
creating fava_dashboards.egg-info
writing fava_dashboards.egg-info/PKG-INFO
writing dependency_links to fava_dashboards.egg-info/dependency_links.txt
writing requirements to fava_dashboards.egg-info/requires.txt
writing top-level names to fava_dashboards.egg-info/top_level.txt
writing manifest file 'fava_dashboards.egg-info/SOURCES.txt'
adding license file 'LICENSE.md'
writing manifest file 'fava_dashboards.egg-info/SOURCES.txt'
/usr/lib/python3.11/site-packages/setuptools/command/build_py.py:201: _Warning: Package 'fava_dashboards.templates' is absent from the `packages` configuration.
!!

        ********************************************************************************
        ############################
        # Package would be ignored #
        ############################
        Python recognizes 'fava_dashboards.templates' as an importable package[^1],
        but it is absent from setuptools' `packages` configuration.

        This leads to an ambiguous overall configuration. If you want to distribute this
        package, please make sure that 'fava_dashboards.templates' is explicitly added
        to the `packages` configuration field.

        Alternatively, you can also rely on setuptools' discovery methods
        (for example by using `find_namespace_packages(...)`/`find_namespace:`
        instead of `find_packages(...)`/`find:`).

        You can read more about "package discovery" on setuptools documentation page:

        - https://setuptools.pypa.io/en/latest/userguide/package_discovery.html

        If you don't want 'fava_dashboards.templates' to be distributed and are
        already explicitly excluding 'fava_dashboards.templates' via
        `find_namespace_packages(...)/find_namespace` or `find_packages(...)/find`,
        you can try to use `exclude_package_data`, or `include-package-data=False` in
        combination with a more fine grained `package-data` configuration.

        You can read more about "package data files" on setuptools documentation page:

        - https://setuptools.pypa.io/en/latest/userguide/datafiles.html


        [^1]: For Python, any directory (with suitable naming) can be imported,
              even if it does not contain any `.py` files.
              On the other hand, currently there is no concept of package data
              directory, all directories are treated like packages.
        ********************************************************************************

!!
  check.warn(importable)
copying fava_dashboards/FavaDashboards.js -> build/lib/fava_dashboards
[...]
@andreasgerstmayr
Copy link
Owner

@AlphaJack could you check if #19 solves this issue?

@AlphaJack
Copy link
Author

Yes it does!

@andreasgerstmayr
Copy link
Owner

Thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants