Conversation
| label: time.bind(), | ||
| }), | ||
| onClicked: () => Utils.execAsync("swaync-client -t"), | ||
| on_clicked: () => App.toggleWindow("timemenu"), |
There was a problem hiding this comment.
I think a better name for the window would be notification-center, same for the file name
There was a problem hiding this comment.
lmao
(ps: why not name it option.ts?)
| enable: opt<boolean>(true), | ||
| }, | ||
| }, | ||
| development: opt<boolean>(false), |
There was a problem hiding this comment.
maybe instead an environment variable could be used for this
| @@ -0,0 +1,18 @@ | |||
| export function SetupCssHotReload(dest: string) { | |||
There was a problem hiding this comment.
| export function SetupCssHotReload(dest: string) { | |
| export function setupCssHotReload(dest: string) { |
| // Set up hot reloading of styles. | ||
| Utils.monitorFile(`${App.configDir}/style.scss`, (_, event) => { | ||
| if (event !== 0) { | ||
| // Not a changed event. | ||
| return; | ||
| } | ||
|
|
||
| print("Hot reloading styles."); | ||
| Promise.resolve(compileStyles(dest)) | ||
| .then((_) => { | ||
| App.resetCss(); | ||
| App.applyCss(`${dest}/style.css`); | ||
| }) | ||
| .catch((reason) => { | ||
| print(`Hot reloading error: ${reason}`); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Did you intend to include the code for hot reloading twice? (here and in the develop.ts file)
| } No newline at end of file | ||
| } | ||
|
|
||
| .timemenu { |
There was a problem hiding this comment.
I would also rename the style to notification-center
ags/timemenu/icon.ts
Outdated
| const icon = Option.from(app_entry) | ||
| .andThen(iconAsOption) | ||
| .orElse(() => iconAsOption(app_icon)) | ||
| .unwrapOr(""); // TODO: Add some fallback icon here.; |
There was a problem hiding this comment.
GNOME uses application-x-executable-symbolic, i think that is probably the most appropriate. Im assuming this is the icon of the app sending the notification and not the custom icon provided in the notification itself.
EDIT: item-missing-symbolic is also nice, idk which one i prefer
|
It seems like this makes it so the service now always tries to be the notification daemon. This may be a problem if someone wants to use their own notification daemon. IMO there should be an option to disable mithril's notifications. Currently in AGS impoting the notifications service registers the program as a notification daemon so this would have to be worked around. |
2 participants
It does not look good, nor does it have all the functionality it should have. I decided to create this PR because I no longer wanted to block the feature.
Closes #8