feat: let stylix colors be overridden#23
Merged
andreashgk merged 1 commit intoandreashgk:mainfrom Jul 27, 2025
Merged
Conversation
Instead of treating Stylix colors and `theme.colors` separately, this makes the Stylix integration overridde the default values for `theme.colors`, which can in turn still be overridden.
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of treating Stylix colors and
theme.colorsseparately, this makes the Stylix integration overridde the default values fortheme.colors, which can in turn still be overridden.My motivation behind this is to override the primary color, which is set to
base0Cby the Stylix integration, even though I preferbase0D. This makes it possible to enable the Stylix configuration and overrideconfig.services.mithril-shell.theme.colors.primaryin order to achieve this.