Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When lighthouse cannot reach site, lighthouse-ci reports all tests passing #56

Closed
glassdimly opened this issue Oct 16, 2019 · 1 comment

Comments

@glassdimly
Copy link

What happens
Here's what lighthouse-ci generates:
image

Here's what lighthouse cli generates from the same site.

lighthouse http://local.mysite.org
  ...
Runtime error encountered: Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 503)

What should happen
If lighthouse returns a 503, lighthouse-ci should report a fail, or fail all tests.

@andreasonny83
Copy link
Owner

First of all, thanks for your help @glassdimly

To be honest, that doesn't really sound like a bug to me.
The problem is that, when providing an invalid URL to Chrome, the page is still rendering something depending on your Internet provider. You cannot see an error page directly in Chrome as it defaults to some content instead.

Also, checking the existence of the website could be generally done before running performance tests, via E2E tests or integrations.

Closing this issue for now. Please, feel free to reopen if you don't agree or you have more questions.

andreasonny83 added a commit that referenced this issue Oct 2, 2020
Report errors and warnings from the target website

Closes #62, #56
andreasonny83 added a commit that referenced this issue Oct 2, 2020
* feat(lighthouse-reporter): Better reports

Report errors and warnings from the target website

Closes #62, #56

* test(core): Fix formatting and tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants