test: ensure that the reporter is working correctly
#72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
marcschaller
commented
Jul 17, 2020
Comment on lines
+137
to
+143
| const lighthouseResult = await launchChromeAndRunLighthouse( | ||
| url, | ||
| [...defaultChromeFlags, ...customChromeFlags], | ||
| extraLHFlags, | ||
| configPath, | ||
| budgetPath, | ||
| ); |
There was a problem hiding this comment.
This change comes from the pull request #71, and will be discarded as soon as the previous PR is merged (and this one rebased).
andreasonny83
approved these changes
Jul 17, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new test that will generate a
lighthouse-cireport onhttp://www.google.com, to ensure that future changes won't break this feature.See also #71.