enable unnecessary_new

analysis_options.yaml

@@ -124,6 +124,7 @@ linter:
     - unnecessary_const
     - unnecessary_getters_setters
     # - unnecessary_lambdas # https://github.com/dart-lang/linter/issues/498
+    - unnecessary_new
     - unnecessary_null_aware_assignments
     - unnecessary_null_in_if_null_operators
     # - unnecessary_overrides # https://github.com/dart-lang/linter/issues/626 and https://github.com/dart-lang/linter/issues/627

packages/android_alarm_manager/example/lib/main.dart

@@ -42,8 +42,8 @@ class HelloMessage {
 void printHelloMessage(String msg) {
   ensureFirebaseUser().then((_) {
     firebaseUser.getIdToken().then((String idToken) {
-      print(new HelloMessage(
-        new DateTime.now(),
+      print(HelloMessage(
+        DateTime.now(),
         msg,
         Isolate.current.hashCode,
         firebaseUser,

packages/android_alarm_manager/lib/android_alarm_manager.dart

@@ -44,7 +44,7 @@ class AndroidAlarmManager {
     bool exact = false,
     bool wakeup = false,
   }) async {
-    final int now = new DateTime.now().millisecondsSinceEpoch;
+    final int now = DateTime.now().millisecondsSinceEpoch;
     final int first = now + delay.inMilliseconds;
     final String functionName = _nameOfFunction(callback);
     if (functionName == null) {
@@ -84,7 +84,7 @@ class AndroidAlarmManager {
     bool exact = false,
     bool wakeup = false,
   }) async {
-    final int now = new DateTime.now().millisecondsSinceEpoch;
+    final int now = DateTime.now().millisecondsSinceEpoch;
     final int period = duration.inMilliseconds;
     final int first = now + period;
     final String functionName = _nameOfFunction(callback);

packages/android_intent/example/lib/main.dart

@@ -7,19 +7,19 @@ import 'package:flutter/material.dart';
 import 'package:platform/platform.dart';
 
 void main() {
-  runApp(new MyApp());
+  runApp(MyApp());
 }
 
 class MyApp extends StatelessWidget {
   // This widget is the root of your application.
   @override
   Widget build(BuildContext context) {
-    return new MaterialApp(
+    return MaterialApp(
       title: 'Flutter Demo',
-      theme: new ThemeData(
+      theme: ThemeData(
         primarySwatch: Colors.blue,
       ),
-      home: new MyHomePage(),
+      home: MyHomePage(),
       routes: <String, WidgetBuilder>{
         ExplicitIntentsWidget.routeName: (BuildContext context) =>
             const ExplicitIntentsWidget()
@@ -51,17 +51,17 @@ class MyHomePage extends StatelessWidget {
   Widget build(BuildContext context) {
     Widget body;
     if (const LocalPlatform().isAndroid) {
-      body = new Padding(
+      body = Padding(
         padding: const EdgeInsets.symmetric(vertical: 15.0),
-        child: new Column(
+        child: Column(
           mainAxisAlignment: MainAxisAlignment.spaceEvenly,
           children: <Widget>[
-            new RaisedButton(
+            RaisedButton(
               child: const Text(
                   'Tap here to set an alarm\non weekdays at 9:30pm.'),
               onPressed: _createAlarm,
             ),
-            new RaisedButton(
+            RaisedButton(
                 child: const Text('Tap here to test explicit intents.'),
                 onPressed: () => _openExplicitIntentsView(context)),
           ],
@@ -70,11 +70,11 @@ class MyHomePage extends StatelessWidget {
     } else {
       body = const Text('This plugin only works with Android');
     }
-    return new Scaffold(
-      appBar: new AppBar(
+    return Scaffold(
+      appBar: AppBar(
         title: const Text('Plugin example app'),
       ),
-      body: new Center(child: body),
+      body: Center(child: body),
     );
   }
 }
@@ -85,23 +85,23 @@ class ExplicitIntentsWidget extends StatelessWidget {
   const ExplicitIntentsWidget();
 
   void _openGoogleMapsStreetView() {
-    final AndroidIntent intent = new AndroidIntent(
+    final AndroidIntent intent = AndroidIntent(
         action: 'action_view',
         data: Uri.encodeFull('google.streetview:cbll=46.414382,10.013988'),
         package: 'com.google.android.apps.maps');
     intent.launch();
   }
 
   void _displayMapInGoogleMaps({int zoomLevel = 12}) {
-    final AndroidIntent intent = new AndroidIntent(
+    final AndroidIntent intent = AndroidIntent(
         action: 'action_view',
         data: Uri.encodeFull('geo:37.7749,-122.4194?z=$zoomLevel'),
         package: 'com.google.android.apps.maps');
     intent.launch();
   }
 
   void _launchTurnByTurnNavigationInGoogleMaps() {
-    final AndroidIntent intent = new AndroidIntent(
+    final AndroidIntent intent = AndroidIntent(
         action: 'action_view',
         data: Uri.encodeFull(
             'google.navigation:q=Taronga+Zoo,+Sydney+Australia&avoid=tf'),
@@ -110,15 +110,15 @@ class ExplicitIntentsWidget extends StatelessWidget {
   }
 
   void _openLinkInGoogleChrome() {
-    final AndroidIntent intent = new AndroidIntent(
+    final AndroidIntent intent = AndroidIntent(
         action: 'action_view',
         data: Uri.encodeFull('https://flutter.io'),
         package: 'com.android.chrome');
     intent.launch();
   }
 
   void _testExplicitIntentFallback() {
-    final AndroidIntent intent = new AndroidIntent(
+    final AndroidIntent intent = AndroidIntent(
         action: 'action_view',
         data: Uri.encodeFull('https://flutter.io'),
         package: 'com.android.chrome.implicit.fallback');
@@ -127,35 +127,35 @@ class ExplicitIntentsWidget extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    return new Scaffold(
-      appBar: new AppBar(
+    return Scaffold(
+      appBar: AppBar(
         title: const Text('Test explicit intents'),
       ),
-      body: new Center(
-        child: new Padding(
+      body: Center(
+        child: Padding(
           padding: const EdgeInsets.symmetric(vertical: 15.0),
-          child: new Column(
+          child: Column(
             mainAxisAlignment: MainAxisAlignment.spaceEvenly,
             children: <Widget>[
-              new RaisedButton(
+              RaisedButton(
                 child: const Text(
                     'Tap here to display panorama\nimagery in Google Street View.'),
                 onPressed: _openGoogleMapsStreetView,
               ),
-              new RaisedButton(
+              RaisedButton(
                 child: const Text('Tap here to display\na map in Google Maps.'),
                 onPressed: _displayMapInGoogleMaps,
               ),
-              new RaisedButton(
+              RaisedButton(
                 child: const Text(
                     'Tap here to launch turn-by-turn\nnavigation in Google Maps.'),
                 onPressed: _launchTurnByTurnNavigationInGoogleMaps,
               ),
-              new RaisedButton(
+              RaisedButton(
                 child: const Text('Tap here to open link in Google Chrome.'),
                 onPressed: _openLinkInGoogleChrome,
               ),
-              new RaisedButton(
+              RaisedButton(
                 child: const Text(
                     'Tap here to test explicit intent fallback to implicit.'),
                 onPressed: _testExplicitIntentFallback,

packages/battery/example/lib/main.dart

@@ -8,18 +8,18 @@ import 'package:flutter/material.dart';
 import 'package:battery/battery.dart';
 
 void main() {
-  runApp(new MyApp());
+  runApp(MyApp());
 }
 
 class MyApp extends StatelessWidget {
   @override
   Widget build(BuildContext context) {
-    return new MaterialApp(
+    return MaterialApp(
       title: 'Flutter Demo',
-      theme: new ThemeData(
+      theme: ThemeData(
         primarySwatch: Colors.blue,
       ),
-      home: new MyHomePage(title: 'Flutter Demo Home Page'),
+      home: MyHomePage(title: 'Flutter Demo Home Page'),
     );
   }
 }
@@ -30,11 +30,11 @@ class MyHomePage extends StatefulWidget {
   final String title;
 
   @override
-  _MyHomePageState createState() => new _MyHomePageState();
+  _MyHomePageState createState() => _MyHomePageState();
 }
 
 class _MyHomePageState extends State<MyHomePage> {
-  Battery _battery = new Battery();
+  Battery _battery = Battery();
 
   BatteryState _batteryState;
   StreamSubscription<BatteryState> _batteryStateSubscription;
@@ -52,23 +52,23 @@ class _MyHomePageState extends State<MyHomePage> {
 
   @override
   Widget build(BuildContext context) {
-    return new Scaffold(
-      appBar: new AppBar(
+    return Scaffold(
+      appBar: AppBar(
         title: const Text('Plugin example app'),
       ),
-      body: new Center(
-        child: new Text('$_batteryState'),
+      body: Center(
+        child: Text('$_batteryState'),
       ),
-      floatingActionButton: new FloatingActionButton(
+      floatingActionButton: FloatingActionButton(
         child: const Icon(Icons.battery_unknown),
         onPressed: () async {
           final int batteryLevel = await _battery.batteryLevel;
           showDialog<Null>(
             context: context,
-            builder: (_) => new AlertDialog(
-                  content: new Text('Battery: $batteryLevel%'),
+            builder: (_) => AlertDialog(
+                  content: Text('Battery: $batteryLevel%'),
                   actions: <Widget>[
-                    new FlatButton(
+                    FlatButton(
                       child: const Text('OK'),
                       onPressed: () {
                         Navigator.pop(context);

packages/battery/lib/battery.dart

@@ -17,7 +17,7 @@ class Battery {
           const MethodChannel('plugins.flutter.io/battery');
       final EventChannel eventChannel =
           const EventChannel('plugins.flutter.io/charging');
-      _instance = new Battery.private(methodChannel, eventChannel);
+      _instance = Battery.private(methodChannel, eventChannel);
     }
     return _instance;
   }
@@ -56,6 +56,6 @@ BatteryState _parseBatteryState(String state) {
     case 'discharging':
       return BatteryState.discharging;
     default:
-      throw new ArgumentError('$state is not a valid BatteryState.');
+      throw ArgumentError('$state is not a valid BatteryState.');
   }
 }

packages/battery/test/battery_test.dart

@@ -16,22 +16,22 @@ void main() {
   Battery battery;
 
   setUp(() {
-    methodChannel = new MockMethodChannel();
-    eventChannel = new MockEventChannel();
-    battery = new Battery.private(methodChannel, eventChannel);
+    methodChannel = MockMethodChannel();
+    eventChannel = MockEventChannel();
+    battery = Battery.private(methodChannel, eventChannel);
   });
 
   test('batteryLevel', () async {
     when(methodChannel.invokeMethod('getBatteryLevel'))
-        .thenReturn(new Future<int>.value(42));
+        .thenReturn(Future<int>.value(42));
     expect(await battery.batteryLevel, 42);
   });
 
   group('battery state', () {
     StreamController<String> controller;
 
     setUp(() {
-      controller = new StreamController<String>();
+      controller = StreamController<String>();
       when(eventChannel.receiveBroadcastStream()).thenReturn(controller.stream);
     });
 
@@ -48,7 +48,7 @@ void main() {
 
     test('receive values', () async {
       final StreamQueue<BatteryState> queue =
-          new StreamQueue<BatteryState>(battery.onBatteryStateChanged);
+          StreamQueue<BatteryState>(battery.onBatteryStateChanged);
 
       controller.add("full");
       expect(await queue.next, BatteryState.full);