Revert "enable lint prefer_void_to_null (flutter#858)"

This reverts commit 5c2c36c.

analysis_options.yaml

@@ -112,7 +112,6 @@ linter:
     # - prefer_interpolation_to_compose_strings # not yet tested
     - prefer_is_empty
     - prefer_is_not_empty
-    - prefer_void_to_null
     # - recursive_getters # https://github.com/dart-lang/linter/issues/452
     - slash_for_doc_comments
     - sort_constructors_first

packages/android_alarm_manager/example/lib/main.dart

@@ -12,7 +12,7 @@ import 'package:flutter/widgets.dart';
 final FirebaseAuth firebaseAuth = FirebaseAuth.instance;
 FirebaseUser firebaseUser;
 
-Future<void> ensureFirebaseUser() async {
+Future<Null> ensureFirebaseUser() async {
   if (firebaseUser == null) {
     firebaseUser = await firebaseAuth.currentUser();
     if (firebaseUser == null) {
@@ -67,7 +67,7 @@ void printOneShot() {
   printHelloMessage("Hello, once!");
 }
 
-Future<void> main() async {
+Future<Null> main() async {
   final int helloAlarmID = 0;
   final int goodbyeAlarmID = 1;
   final int oneShotID = 2;

packages/android_intent/lib/android_intent.dart

@@ -42,7 +42,7 @@ class AndroidIntent {
   ///
   /// This works only on Android platforms. Please guard the call so that your
   /// iOS app does not crash. Checked mode will throw an assert exception.
-  Future<void> launch() async {
+  Future<Null> launch() async {
     assert(_platform.isAndroid);
     final Map<String, dynamic> args = <String, dynamic>{'action': action};
     if (category != null) {

packages/battery/example/lib/main.dart

@@ -63,7 +63,7 @@ class _MyHomePageState extends State<MyHomePage> {
         child: const Icon(Icons.battery_unknown),
         onPressed: () async {
           final int batteryLevel = await _battery.batteryLevel;
-          showDialog<void>(
+          showDialog<Null>(
             context: context,
             builder: (_) => AlertDialog(
                   content: Text('Battery: $batteryLevel%'),

packages/camera/README.md

@@ -48,7 +48,7 @@ import 'package:camera/camera.dart';
 
 List<CameraDescription> cameras;
 
-Future<void> main() async {
+Future<Null> main() async {
   cameras = await availableCameras();
   runApp(CameraApp());
 }

packages/camera/example/lib/main.dart

@@ -356,7 +356,7 @@ class CameraApp extends StatelessWidget {
 
 List<CameraDescription> cameras;
 
-Future<void> main() async {
+Future<Null> main() async {
   // Fetch the available cameras before initializing the app.
   try {
     cameras = await availableCameras();

packages/camera/lib/camera.dart

@@ -185,17 +185,17 @@ class CameraController extends ValueNotifier<CameraValue> {
   int _textureId;
   bool _isDisposed = false;
   StreamSubscription<dynamic> _eventSubscription;
-  Completer<void> _creatingCompleter;
+  Completer<Null> _creatingCompleter;
 
   /// Initializes the camera on the device.
   ///
   /// Throws a [CameraException] if the initialization fails.
-  Future<void> initialize() async {
+  Future<Null> initialize() async {
     if (_isDisposed) {
-      return Future<void>.value();
+      return Future<Null>.value(null);
     }
     try {
-      _creatingCompleter = Completer<void>();
+      _creatingCompleter = Completer<Null>();
       final Map<dynamic, dynamic> reply = await _channel.invokeMethod(
         'initialize',
         <String, dynamic>{
@@ -218,7 +218,7 @@ class CameraController extends ValueNotifier<CameraValue> {
         EventChannel('flutter.io/cameraPlugin/cameraEvents$_textureId')
             .receiveBroadcastStream()
             .listen(_listener);
-    _creatingCompleter.complete();
+    _creatingCompleter.complete(null);
     return _creatingCompleter.future;
   }
 
@@ -250,7 +250,7 @@ class CameraController extends ValueNotifier<CameraValue> {
   /// The file can be read as this function returns.
   ///
   /// Throws a [CameraException] if the capture fails.
-  Future<void> takePicture(String path) async {
+  Future<Null> takePicture(String path) async {
     if (!value.isInitialized || _isDisposed) {
       throw CameraException(
         'Uninitialized CameraController.',
@@ -286,7 +286,7 @@ class CameraController extends ValueNotifier<CameraValue> {
   /// The file can be read as soon as [stopVideoRecording] returns.
   ///
   /// Throws a [CameraException] if the capture fails.
-  Future<void> startVideoRecording(String filePath) async {
+  Future<Null> startVideoRecording(String filePath) async {
     if (!value.isInitialized || _isDisposed) {
       throw CameraException(
         'Uninitialized CameraController',
@@ -311,7 +311,7 @@ class CameraController extends ValueNotifier<CameraValue> {
   }
 
   /// Stop recording.
-  Future<void> stopVideoRecording() async {
+  Future<Null> stopVideoRecording() async {
     if (!value.isInitialized || _isDisposed) {
       throw CameraException(
         'Uninitialized CameraController',
@@ -337,19 +337,22 @@ class CameraController extends ValueNotifier<CameraValue> {
 
   /// Releases the resources of this camera.
   @override
-  Future<void> dispose() async {
+  Future<Null> dispose() async {
     if (_isDisposed) {
-      return;
+      return Future<Null>.value(null);
     }
     _isDisposed = true;
     super.dispose();
-    if (_creatingCompleter != null) {
-      await _creatingCompleter.future;
-      await _channel.invokeMethod(
-        'dispose',
-        <String, dynamic>{'textureId': _textureId},
-      );
-      await _eventSubscription?.cancel();
+    if (_creatingCompleter == null) {
+      return Future<Null>.value(null);
+    } else {
+      return _creatingCompleter.future.then((_) async {
+        await _channel.invokeMethod(
+          'dispose',
+          <String, dynamic>{'textureId': _textureId},
+        );
+        await _eventSubscription?.cancel();
+      });
     }
   }
 }

packages/cloud_firestore/example/lib/main.dart

@@ -57,7 +57,7 @@ class MyHomePage extends StatelessWidget {
   final Firestore firestore;
   CollectionReference get messages => firestore.collection('messages');
 
-  Future<void> _addMessage() async {
+  Future<Null> _addMessage() async {
     await messages.add(<String, dynamic>{
       'message': 'Hello world!',
       'created_at': FieldValue.serverTimestamp(),

packages/cloud_firestore/lib/src/write_batch.dart

@@ -25,11 +25,11 @@ class WriteBatch {
   /// Commits all of the writes in this write batch as a single atomic unit.
   ///
   /// Calling this method prevents any future operations from being added.
-  Future<void> commit() async {
+  Future<Null> commit() async {
     if (!_committed) {
       _committed = true;
       await Future.wait<dynamic>(_actions);
-      await Firestore.channel.invokeMethod(
+      return await Firestore.channel.invokeMethod(
           'WriteBatch#commit', <String, dynamic>{'handle': await _handle});
     } else {
       throw StateError("This batch has already been committed.");

packages/cloud_firestore/test/cloud_firestore_test.dart

@@ -279,7 +279,7 @@ void main() {
         expect(document.reference.path, equals('foo/0'));
         expect(document.data, equals(kMockDocumentSnapshotData));
         // Flush the async removeListener call
-        await Future<void>.delayed(Duration.zero);
+        await Future<Null>.delayed(Duration.zero);
         expect(log, <Matcher>[
           isMethodCall(
             'Query#addSnapshotListener',
@@ -305,7 +305,7 @@ void main() {
                 .snapshots()
                 .listen((QuerySnapshot querySnapshot) {});
         subscription.cancel();
-        await Future<void>.delayed(Duration.zero);
+        await Future<Null>.delayed(Duration.zero);
         expect(
           log,
           equals(<Matcher>[
@@ -336,7 +336,7 @@ void main() {
                 .snapshots()
                 .listen((QuerySnapshot querySnapshot) {});
         subscription.cancel();
-        await Future<void>.delayed(Duration.zero);
+        await Future<Null>.delayed(Duration.zero);
         expect(
           log,
           equals(<Matcher>[
@@ -367,7 +367,7 @@ void main() {
                 .snapshots()
                 .listen((QuerySnapshot querySnapshot) {});
         subscription.cancel();
-        await Future<void>.delayed(Duration.zero);
+        await Future<Null>.delayed(Duration.zero);
         expect(
           log,
           equals(<Matcher>[
@@ -401,7 +401,7 @@ void main() {
         expect(snapshot.reference.path, equals('path/to/foo'));
         expect(snapshot.data, equals(kMockDocumentSnapshotData));
         // Flush the async removeListener call
-        await Future<void>.delayed(Duration.zero);
+        await Future<Null>.delayed(Duration.zero);
         expect(
           log,
           <Matcher>[

packages/connectivity/example/lib/main.dart

@@ -57,7 +57,7 @@ class _MyHomePageState extends State<MyHomePage> {
   }
 
   // Platform messages are asynchronous, so we initialize in an async method.
-  Future<void> initConnectivity() async {
+  Future<Null> initConnectivity() async {
     String connectionStatus;
     // Platform messages may fail, so we use a try/catch PlatformException.
     try {

packages/device_info/example/lib/main.dart

@@ -33,7 +33,7 @@ class _MyAppState extends State<MyApp> {
     initPlatformState();
   }
 
-  Future<void> initPlatformState() async {
+  Future<Null> initPlatformState() async {
     Map<String, dynamic> deviceData;
 
     try {

packages/firebase_admob/lib/firebase_admob.dart

@@ -501,7 +501,7 @@ class FirebaseAdMob {
       }
     }
 
-    return Future<dynamic>.value(null);
+    return Future<Null>(null);
   }
 }
 

packages/firebase_analytics/example/lib/main.dart

@@ -61,7 +61,7 @@ class _MyHomePageState extends State<MyHomePage> {
     });
   }
 
-  Future<void> _sendAnalyticsEvent() async {
+  Future<Null> _sendAnalyticsEvent() async {
     await analytics.logEvent(
       name: 'test_event',
       parameters: <String, dynamic>{
@@ -75,41 +75,41 @@ class _MyHomePageState extends State<MyHomePage> {
     setMessage('logEvent succeeded');
   }
 
-  Future<void> _testSetUserId() async {
+  Future<Null> _testSetUserId() async {
     await analytics.setUserId('some-user');
     setMessage('setUserId succeeded');
   }
 
-  Future<void> _testSetCurrentScreen() async {
+  Future<Null> _testSetCurrentScreen() async {
     await analytics.setCurrentScreen(
       screenName: 'Analytics Demo',
       screenClassOverride: 'AnalyticsDemo',
     );
     setMessage('setCurrentScreen succeeded');
   }
 
-  Future<void> _testSetAnalyticsCollectionEnabled() async {
+  Future<Null> _testSetAnalyticsCollectionEnabled() async {
     await analytics.android?.setAnalyticsCollectionEnabled(false);
     await analytics.android?.setAnalyticsCollectionEnabled(true);
     setMessage('setAnalyticsCollectionEnabled succeeded');
   }
 
-  Future<void> _testSetMinimumSessionDuration() async {
+  Future<Null> _testSetMinimumSessionDuration() async {
     await analytics.android?.setMinimumSessionDuration(20000);
     setMessage('setMinimumSessionDuration succeeded');
   }
 
-  Future<void> _testSetSessionTimeoutDuration() async {
+  Future<Null> _testSetSessionTimeoutDuration() async {
     await analytics.android?.setSessionTimeoutDuration(2000000);
     setMessage('setSessionTimeoutDuration succeeded');
   }
 
-  Future<void> _testSetUserProperty() async {
+  Future<Null> _testSetUserProperty() async {
     await analytics.setUserProperty(name: 'regular', value: 'indeed');
     setMessage('setUserProperty succeeded');
   }
 
-  Future<void> _testAllEventTypes() async {
+  Future<Null> _testAllEventTypes() async {
     await analytics.logAddPaymentInfo();
     await analytics.logAddToCart(
       currency: 'USD',