Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make assembleProgram more consistent #14

Merged
merged 1 commit into from
Feb 4, 2018
Merged

Make assembleProgram more consistent #14

merged 1 commit into from
Feb 4, 2018

Conversation

andrejewski
Copy link
Owner

@andrejewski andrejewski commented Feb 4, 2018 •
edited
Loading

The initial assembleProgram used keys deps and options but those names are weird. Now we have a consistent naming pattern and now view gets its own options too.

  • data / dataOptions
  • view / viewOptions
  • logic / logicOptions

This is based on my experience weaving programs with dependencies together. Specifically here viewOptions is useful for passing sub-program functions to the parent view.

@andrejewski andrejewski merged commit 84c9449 into master Feb 4, 2018
@andrejewski andrejewski deleted the better-assemble branch February 4, 2018 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andrejewski