No way to run the tests since jbuilder? #32
Comments
|
I'm not the maintainer and can't say if it should be in the README, but have you tried |
|
Thank you. Will try to go back to this comparison function in a few weeks. |
|
Actually |
|
The project was migrated to jbuilder in 2ed2e97, and even though the old build files seem to reference testing, I'm not sure where they are and how to integrate them with dune. Are there any tests in the repo? @rgrinberg, thoughts? |
|
Yeah that seems like an omission on my part. |
|
Is it possible to submit #35, and perhaps have you work on the tests? :) Sorry, I'm a bit swamped at the moment. I could certainly help you out if you have any questions. |
|
I don't mind extending the branch or opening a follow-up pull request, in case you can (quickly) merge #35 first. To that end, how do we integrate the existing tests with Dune? Actually, are there any tests in the repo, and did I fail to uncover them? If there are none, I'm afraid I can't commit to writing them first, since I don't use stdint directly and only did the dune migration to avoid jbuilder in opam-repository. That said, if there are no tests, I don't mind adding a minimum/trivial test, in order to make |
|
I think the spec directory in this project contains a test suite. #35 looks good, but I’m afraid I’m unable to merge it. I’m no a collaborator of this repository.
…On Dec 2, 2019, 10:56 PM +0700, Tuncer Ayaz ***@***.***>, wrote:
I don't mind extending the branch or opening a follow-up pull request, in case you can (quickly) merge #35 first. To that end, how do we integrate the existing tests with Dune? Actually, are there any tests in the repo, and did I fail to uncover them? If there are none, I'm afraid I can't commit to writing them first, since I don't use stdint directly and only did the dune migration to avoid jbuilder in opam-repository.
That said, if there are no tests, I don't mind adding a minimum/trivial test, in order to make runtest do something. That way, someone else can implement a test suite with dune integration already taken care of.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Right, |
|
@rixed would you like to revive the tests perahps? it should be sufficient to functorize common.ml and instantiate for the different integer types. Ospec can be dropped in favor of alcotest or ppx_inline_test. |
|
@rgrinberg I was just looking at it, but ospec uses camlp4 so that's more work that I'm able to spend right now. I might have more time in a few weeks though. |
Those are simpler (only relying on qcheck rather than the unmaintained ospec (https://github.com/andrenth/ospec)). Also believed to be more exhaustive. Also added a few more tests. Not all tests currently pass (11/282 are failing). I believe most of the failures would have failed earlier, would the former tests run on all types. Some of the failure are because of the tests being wrong, some look like genuine errors. Having no time to learn a specific build system for every programming language, I've added a small Makefile that will build and run the tests. I'm confident a dune zealot will quickly and properly merge this into the dune configuration. :) Closes andrenth#32
I can't find how to run the tests since the build system is jbuilder.
Could this be documented in the README maybe?
Note: I suspect the comparison function is wrong for large int128 and would like to fix it
The text was updated successfully, but these errors were encountered: