Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nitpick init: Specify style url(s) in the command line #458

Closed
mjpieters opened this issue Mar 13, 2022 · 3 comments · Fixed by #473
Closed

nitpick init: Specify style url(s) in the command line #458

mjpieters opened this issue Mar 13, 2022 · 3 comments · Fixed by #473
Labels
enhancement New feature or request released Feature/fix is released

Comments

@mjpieters
Copy link
Contributor

Problem

I am advocating the use of nitpick in a larger organisation, by providing them with something copy-paste friendly. This makes adoption of an otherwise overwhelming pile of linters, formatters and tools to support those much, much simpler.

This does require that we use a central style definition, one that supports checks and fixes for internal tools.

Currently, I have to either recreate what nitpick fix does to locate any existing configuration and generate project-appropriate changes or parse the output of nitpick init to see if we need to use sed to replace the default URL.

Possible solution

If nitpick init took URLs as arguments our “bootstrap snippet” can be reduced to:

nitpick init https://org.style.example.com/nitpick.toml
nitpick fix

If no arguments are given the current default behaviour of using the default style is used.

Note that this FR differs from #330; it’s a simple “we took care of everything” path.

@mjpieters mjpieters added the enhancement New feature or request label Mar 13, 2022
@andreoliwa
Copy link
Owner

Hello @mjpieters.

First of all, thank you very much for all the issues and pull requests you created. 🙏🏻
I will read them and take action soon. 🚀

About this URL argument to nitpick init, it is a good idea indeed.

I plan to add more stuff to init, I'll compare with my notes or mental notes.

The plan for #330 is not super accurate anymore (too much hassle), and I didn't update the description.
I didn't think anyone would read it, but hey, thanks again for doing it. 🙂
I'll try to dump my plans somewhere other than my head.

@andreoliwa
Copy link
Owner

I plan to add more stuff to init, I'll compare with my notes or mental notes.

@mjpieters This is actually what I had in mind for nitpick init higher in the priority list: #331
Check it out and let me know if you think the feature is useful.

I already mentioned this issue there, they can co-exist in harmony.

The plan for #330 is not super accurate anymore (too much hassle), and I didn't update the description.

#330 is still valid.
It's just too much work (creating a UI for the CLI) and not that necessary anymore.

@github-actions
Copy link

🎉 This issue has been resolved in version 0.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Feature/fix is released label Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released Feature/fix is released
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants