Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set initial style url(s) with nitpick init #473

Merged
merged 1 commit into from
Mar 26, 2022

Conversation

mjpieters
Copy link
Contributor

This allows for a project to set their initial style URLs with the command-line, rather than defaulting to the standard URL:

$ nitpick init http://example.com/style1 ./local/style2

Issues fixed by this pull request:

Fix #458

Checklist

  • Read the contribution guidelines
  • Run make locally before pushing commits
  • Add tests for the relevant parts:
    • API
    • CLI
    • flake8 plugin (normal mode)
    • flake8 plugin (offline mode)
  • Write documentation when there's a new API or functionality

@mjpieters
Copy link
Contributor Author

mjpieters commented Mar 25, 2022

This draft PR is dependent on #470 (saves me re-basing). I'll submit this once the other PR is done; if that PR isn't going to be merged I'll rebase this onto develop without the changes in that PR.

The change unique to this PR can be viewed by selecting the single commit.

@coveralls
Copy link

coveralls commented Mar 25, 2022

Pull Request Test Coverage Report for Build 2044663560

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 96.443%

Totals Coverage Status
Change from base Build 2044372370: 0.009%
Covered Lines: 2012
Relevant Lines: 2068

💛 - Coveralls

Copy link
Owner

@andreoliwa andreoliwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The draft looks good. 👍🏻
I'll approve it when it's ready for review.

docs/configuration.rst Outdated Show resolved Hide resolved
@mjpieters mjpieters force-pushed the init_args branch 2 times, most recently from 43c5d41 to de4d5f0 Compare March 26, 2022 13:18
@mjpieters mjpieters marked this pull request as ready for review March 26, 2022 13:19
@mjpieters
Copy link
Contributor Author

The draft looks good. 👍🏻
I'll approve it when it's ready for review.

All done and ready to go!

This allows for a project to set their initial style URLs with the command-line, rather than defaulting to the standard URL:

```sh
$ nitpick init http://example.com/style1 ./local/style2
```
Copy link
Owner

@andreoliwa andreoliwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great feature. Thanks! 🚀

@andreoliwa andreoliwa merged commit 0100f2b into andreoliwa:develop Mar 26, 2022
github-actions bot pushed a commit that referenced this pull request Mar 27, 2022
# [0.32.0](v0.31.0...v0.32.0) (2022-03-27)

### Bug Fixes

* **deps:** update dependency pytest-socket to a commit hash ([#440](#440)) ([61ac278](61ac278))
* GitHub URL should preserve query args ([#453](#453)) ([a2b97b1](a2b97b1))
* use built-in preset as default style ([#450](#450)) ([68fa2ce](68fa2ce))

### Features

* add --version cli switch (thanks to [@mjpieters](https://github.com/mjpieters)) ([#468](#468)) ([6a85f79](6a85f79))
* resolve relative URIs in nitpick.styles.include ([#470](#470)) ([ec934dc](ec934dc))
* set initial style url(s) with nitpick init ([#473](#473)) ([0100f2b](0100f2b))
* switch to requests-cache for style caching ([#467](#467)) ([c586d7f](c586d7f))
@github-actions
Copy link

🎉 This PR is included in version 0.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Feature/fix is released label Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Feature/fix is released
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

nitpick init: Specify style url(s) in the command line
3 participants