feat: replace skip_step: with skip_build and skip_install
#85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When skipping `build` it was also skipping `install`. However, `install` might be needed to install an `size-limit` preset. One may want to skip `build` (e.g. if the `size` scripts builds first as per size-limit's doc) without skipping `install`. Splitting the options gives more flexibility to the user.
fryorcraken
force-pushed
the
install-without-build
branch
from
035a83a to
e92c6d4
Compare
fryorcraken
changed the title
skip_step: 'all' optionskip_step: with skip_build and skip_install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When skipping
buildit was also skippinginstall.However,
installmight be needed to install ansize-limitpreset.One may want to skip
build(e.g. if thesizescripts builds firstas per size-limit's doc) without skipping
install.Adding the
alloption gives more flexibility to the user.Fixes #84