Fix previously hidden unit test failures (cryostatio#512)

* Remove null test cases and change incorrect Matcher functionality

* Fix incorrect class mocking which causes tests to pass for the wrong reason

* Maintain consistency between tests by allowing use of the same recording name

src/main/java/io/cryostat/net/web/handlers/TargetRecordingOptionsPatchHandler.java

@@ -106,7 +106,7 @@ void handleAuthenticated(RoutingContext ctx) throws Exception {
         MultiMap attrs = ctx.request().formAttributes();
         if (attrs.contains("toDisk")) {
             Matcher m = bool.matcher(attrs.get("toDisk"));
-            if (!m.find()) throw new HttpStatusException(400, "Invalid options");
+            if (!m.matches()) throw new HttpStatusException(400, "Invalid options");
         }
         Arrays.asList("maxAge", "maxSize")
                 .forEach(

src/main/java/io/cryostat/net/web/handlers/TargetRecordingsPostHandler.java

@@ -170,7 +170,7 @@ void handleAuthenticated(RoutingContext ctx) throws Exception {
                                 if (attrs.contains("toDisk")) {
                                     Pattern bool = Pattern.compile("true|false");
                                     Matcher m = bool.matcher(attrs.get("toDisk"));
-                                    if (!m.find())
+                                    if (!m.matches())
                                         throw new HttpStatusException(400, "Invalid options");
                                     builder = builder.toDisk(Boolean.valueOf(attrs.get("toDisk")));
                                 }

src/test/java/io/cryostat/net/web/handlers/TargetRecordingOptionsPatchHandlerTest.java

@@ -174,12 +174,10 @@ void shouldThrowInvalidOptionException(Map<String, String> defaultValues) throws
 
     private static Stream<Map<String, String>> getRequestMaps() {
         return Stream.of(
-                Map.of("toDisk", null),
                 Map.of("toDisk", ""),
                 Map.of("toDisk", "5"),
                 Map.of("toDisk", "T"),
                 Map.of("toDisk", "false1"),
-                Map.of("maxAge", null),
                 Map.of("maxAge", ""),
                 Map.of("maxAge", "true"),
                 Map.of("maxAge", "1e3"),

src/test/java/io/cryostat/net/web/handlers/TargetRecordingsPostHandlerTest.java

@@ -300,6 +300,15 @@ void shouldThrowInvalidOptionException(Map<String, String> requestValues) throws
                                                 arg0.getArgument(1))
                                         .execute(connection));
         Mockito.when(connection.getService()).thenReturn(service);
+        Mockito.when(service.getAvailableRecordings())
+                .thenReturn(Collections.emptyList())
+                .thenReturn(Arrays.asList(existingRecording));
+        RecordingOptionsBuilder recordingOptionsBuilder =
+                Mockito.mock(RecordingOptionsBuilder.class);
+        Mockito.when(recordingOptionsBuilderFactory.create(Mockito.any()))
+                .thenReturn(recordingOptionsBuilder);
+        Mockito.when(recordingOptionsBuilder.name(Mockito.any()))
+                .thenReturn(recordingOptionsBuilder);
 
         Mockito.when(ctx.pathParam("targetId")).thenReturn("fooHost:9091");
         MultiMap attrs = MultiMap.caseInsensitiveMultiMap();
@@ -317,16 +326,13 @@ void shouldThrowInvalidOptionException(Map<String, String> requestValues) throws
 
     private static Stream<Map<String, String>> getRequestMaps() {
         return Stream.of(
-                Map.of("duration", null),
                 Map.of("duration", ""),
                 Map.of("duration", "t"),
                 Map.of("duration", "90s"),
-                Map.of("toDisk", null),
                 Map.of("toDisk", ""),
                 Map.of("toDisk", "5"),
                 Map.of("toDisk", "T"),
                 Map.of("toDisk", "false1"),
-                Map.of("maxAge", null),
                 Map.of("maxAge", ""),
                 Map.of("maxAge", "true"),
                 Map.of("maxAge", "1e3"),