allow cancellation at end of billing period

[mediavrog]

see https://stripe.com/docs/subscriptions#canceling-a-customers-subscriptions

usage example:
subscription.rb

  # we want customers to use the paid subscription until the paid billing period
  def prepare_for_cancelation
    self.cancel_at_period_end = true
  end

[pcboy]

LGTM

[le-doude]

LGTM

👍 👎

[ACPK]

+1 @andrewculver - Is this ready to be merged?

[shawila]

Probably better to have spaces inside the brackets { at_period_end: true }.

[andrewculver]

@mediavrog Hey, sorry for the delay getting back to you on this! I see the plumbing for actually setting the flag on Stripe, but how were you keeping track of the "still active" status of the subscription in the app? Off the top of my head, even if you send this flag to Stripe, the Rails app will still see the subscription as being canceled. Am I missing something?

[kwent]

Per https://stripe.com/docs/billing/subscriptions/cancel#events.

This PR looks safe to me since it will go through canceled webhook at this end of the billing period instead immediately. status will stay unchanged.