Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't explode if a subscription doesn't exist when being hit from Stripe webhook #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 26 additions & 9 deletions config/initializers/stripe_event.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,26 +2,43 @@
events.subscribe 'charge.failed' do |event|
stripe_id = event.data.object['customer']

subscription = ::Subscription.find_by_stripe_id(stripe_id)
subscription.charge_failed
subscription = ::Subscription.find_by(stripe_id: stripe_id)
if subscription.present?
subscription.charge_failed
else
Rails.logger.warn "Received webhook call for stripe charge.failed event but subscription does not exist for stripe ID #{stripe_id}"
end
end

events.subscribe 'invoice.payment_succeeded' do |event|
stripe_id = event.data.object['customer']
amount = event.data.object['total'].to_f / 100.0
subscription = ::Subscription.find_by_stripe_id(stripe_id)
subscription.payment_succeeded(amount)
subscription = ::Subscription.find_by(stripe_id: stripe_id)
if subscription.present?
subscription.payment_succeeded(amount)
else
Rails.logger.warn "Received webhook call for stripe invoice.payment_succeeded event but subscription does not exist for stripe ID #{stripe_id}"
end
end

events.subscribe 'charge.dispute.created' do |event|
stripe_id = event.data.object['customer']
subscription = ::Subscription.find_by_stripe_id(stripe_id)
subscription.charge_disputed
subscription = ::Subscription.find_by(stripe_id: stripe_id)
if subscription.present?
subscription.charge_disputed
else
Rails.logger.warn "Received webhook call for stripe charge.dispute.created event but subscription does not exist for stripe ID #{stripe_id}"
end
end

events.subscribe 'customer.subscription.deleted' do |event|
stripe_id = event.data.object['customer']
subscription = ::Subscription.find_by_stripe_id(stripe_id)
subscription.subscription_owner.try(:cancel)
subscription = ::Subscription.find_by(stripe_id: stripe_id)

if subscription.present?
subscription.subscription_owner.try(:cancel)
else
Rails.logger.warn "Received webhook call for stripe customer.subscription.deleted event but subscription does not exist for stripe ID #{stripe_id}"
end
end
end
end