Performance improvements #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1: improve `suffix/1` by using pattern matching instead 2: improve `ordinalize/1` by using `IO.iodata_to_binary/1` 3. add some tests to cover more logic branches 4. type spec improved
andrewhao
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for providing this library. I was seeking one like this and found it does exactly what I expect. Perfect!
Such a library may be used widely so the performance matters.
This pull request includes several performance improvements. The performance got noticeably improved, about 2~3x faster on my laptop. Please run
mix run bench/bench.exsif you are interested.For detail information, here is why it works:
:erlang.list_to_binary/1used by it) does almost the same thing but with better performance.condis executed linearly, from top to bottom. On the other hand, pattern matching works atO(log n)cost to find a matching clause. Many conditions can be skipped.Also, this fixes #1
Please have a review at it, thanks~