Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to source install only when binary package does not exist (HTTP 404) #30

Closed
andrewkroh opened this issue Nov 24, 2020 · 0 comments · Fixed by #32
Closed

Fall back to source install only when binary package does not exist (HTTP 404) #30

andrewkroh opened this issue Nov 24, 2020 · 0 comments · Fixed by #32

Comments

@andrewkroh
Copy link
Owner

When the install from a binary package fails it falls back to installing from source. I think the only case where the fallback should occur is when the server responds with a 404 that no binary package exists. Otherwise it's falling back on various IO or permissions errors like

[2020-11-24T13:07:55.561Z] time="2020-11-24T13:07:54Z" level=warning msg="Failed to install Go from binary package. Trying to install from source." error="rename C:\\Users\\jenkins\\.gvm\\versions\\go1.14.7.windows.amd64.tmp\\go C:\\Users\\jenkins\\.gvm\\versions\\go1.14.7.windows.amd64: Access is denied." version=1.14.7

andrewkroh added a commit that referenced this issue Dec 1, 2020
When the install from a binary package fails it falls back to installing from source. Tthe only case where the fallback
should occur is when the server responds with a 404 that no binary package exists. Otherwise it's falling back on
various IO or permissions errors.

Fixes #30
andrewkroh added a commit that referenced this issue Dec 1, 2020
When the install from a binary package fails it falls back to installing from source. Tthe only case where the fallback
should occur is when the server responds with a 404 that no binary package exists. Otherwise it's falling back on
various IO or permissions errors.

Fixes #30
andrewkroh added a commit that referenced this issue Dec 1, 2020
When the install from a binary package fails it falls back to installing from source. Tthe only case where the fallback
should occur is when the server responds with a 404 that no binary package exists. Otherwise it's falling back on
various IO or permissions errors.

Fixes #30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant