Fix EquatableArray.Equals override to avoid an endless recursion and …

…stackoverflow exception (#140)
andrewlock · Sep 30, 2024 · 1c7e4c3 · 1c7e4c3
1 parent d00b684
commit 1c7e4c3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/StronglyTypedIds/EquatableArray.cs b/src/StronglyTypedIds/EquatableArray.cs
@@ -37,7 +37,7 @@ public bool Equals(EquatableArray<T> array)
     /// <sinheritdoc/>
     public override bool Equals(object? obj)
     {
-        return obj is EquatableArray<T> array && Equals(this, array);
+        return obj is EquatableArray<T> array && Equals(array);
     }
 
     /// <sinheritdoc/>

diff --git a/test/StronglyTypedIds.Tests/EqualityTests.cs b/test/StronglyTypedIds.Tests/EqualityTests.cs
@@ -149,4 +149,12 @@ public void ResultWithDiagnosticHasExpectedEqualityBehaviour()
             return new Result<(StructToGenerate, bool)>((instance, true), errors);
         }
     }
+
+    [Fact]
+    public void EquatableArrayOverridenEqualsComparesAsExpected() {
+        var instance = new EquatableArray<string>(["A"]);
+        object comparand = new EquatableArray<string>(["A"]);
+
+        Assert.True(instance.Equals(comparand));
+    }
 }