Staging support #44
Merged
Staging support #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What’s remaining for this is some sort of a test. |
The stage hotkey used to only set 'commit' option which was never consulted, so the stage function was never called. The stage function used to call git add with -N which only created and entry in the index but didn’t stage the file itself. When hitting 's' in commit mode and 'c' in staging mode, ask for confirmation since it could be the user pressed the wrong key. Fixes: #41
andrewshadura
force-pushed
the
fix-staging
branch
from
f2e09f4
to
b73bce7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cis for committing, not confirming)sactually callstagefunction