Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early warning of r-spatial evolution #6

Open
rsbivand opened this issue Aug 27, 2022 · 5 comments
Open

Early warning of r-spatial evolution #6

rsbivand opened this issue Aug 27, 2022 · 5 comments

Comments

@rsbivand
Copy link

Because FRK suggests rgeos and rgdal, it is vulnerable to: https://r-spatial.org/r/2022/04/12/evolution.html. Running revdeps on a platform without rgdal, rgeos or maptools (but sp evolution status 2, using sf for coordinate transformation and CRS definition), I see:
00check.log

My Matrix is current R-forge development 1.4-2, because some of the packages I maintain also needed adapting.

@andrewzm
Copy link
Owner

FRK now passes tests with rgeos and rgdal and that error seen in the CHECK with the Matrix has been sorted. However I'm keeping this issue open as when using sf when finding overlapping polygons on sphere is not giving exactly the same results as rgeos and will need to be investigated further at a later stage (edits in 2022_12_rgdal_dependency/ branch)

@rsbivand
Copy link
Author

rsbivand commented Dec 22, 2022

Is sf branching to s2? Does sf_use_s2(FALSE) help? When the geometries are planar, or s2 use is turned off, GEOS is used (but with a slightly different precision model from rgeos). If the geometries are spherical, and s2 use is on, the s2 library is used instead of GEOS.

@andrewzm
Copy link
Owner

andrewzm commented Jan 29, 2023 via email

@rsbivand
Copy link
Author

@andrewzm rgdal was archived yesterday, so please do move to submit an updated version of FRK as soon as possible. See https://github.com/r-spatial/evolution https://r-spatial.github.io/evolution/ for details.

@andrewzm
Copy link
Owner

andrewzm commented Oct 18, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants