[DO NOT MERGE] Have a different pop-up menu within the platform for traces #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonakshisaxena1
force-pushed
the
removeActionButton
branch
from
83f2ee9 to
167cf6a
Compare
sonakshisaxena1
changed the title
sonakshisaxena1
force-pushed
the
removeActionButton
branch
from
167cf6a to
5e12a7c
Compare
sonakshisaxena1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will be a base of having a different pop-up menu all together for our trace files. Currently, it only detects
.perfettoand.pftracefiles and includes a new "Capture" button at the beginning of the pop-up menu. Upon clicking the "Capture" button, a text is logged and no action is performed. Eventually, we'll include the functionality of re-capture etc. (TBD)Fixes #28
Next Steps (open to discussion):
Remove the actions from the platform that would not be needed by a trace file.