Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Password store ignores selected openkeychain key #482

Closed
dsmaynard opened this issue Jan 31, 2019 · 7 comments
Closed

Password store ignores selected openkeychain key #482

dsmaynard opened this issue Jan 31, 2019 · 7 comments
Assignees
@msfjarvis
Milestone
1.10.0

Comments

@dsmaynard
Copy link

dsmaynard commented Jan 31, 2019 •
edited
Loading

I have two subkeys imported to my openkeychain, each linked to a different yubikey, and both of which have been used to encrypt my passwords. In the password store I have my preferred key selected (call it key 1), yet when I click to view a password, it asks me for the pin/yubikey corresponding to key 2, even though it shows the correct key id (key 1) listed in the Crypto section.

If I delete key 2, then key 1 works fine and I'm able to open the password file. It seems like the password store is just selecting the first key, possibly by alphabetical order, from openkeychain?

Password store v 1.3.2
Openkeychain v 5.2
Pixel 3, Android 9 Pie
@dsmaynard dsmaynard changed the title Password store ignores selected opengpg key Password store ignores selected openkeychain key Jan 31, 2019
@Radtoo
Copy link

Radtoo commented Nov 17, 2019

Observing the same issue with

Password store v 1.3.2
Openkeychain v 5.4

It does seem to only try one of the authorized keys. To work around this issue, you currently have to go to Openkeychain->Apps->Password Store and uncheck the other keys. At least you can avoid deleting the other key(s) this way.

@msfjarvis msfjarvis mentioned this issue Jul 3, 2020
Merged
8 tasks
@msfjarvis msfjarvis added this to the 1.10.0 milestone Jul 3, 2020
@msfjarvis msfjarvis assigned msfjarvis and unassigned zeapo Jul 3, 2020
@msfjarvis
Copy link
Member

This should actually already be resolved in the snapshot build (available here), can someone verify this?

@msfjarvis
Copy link
Member

I can confirm this is fixed, closing the issue.

@msfjarvis msfjarvis mentioned this issue Jul 8, 2020
Merged
8 tasks
msfjarvis pushed a commit that referenced this issue Jul 8, 2020
Mention #482 being fixed in the changelog (#925)
0ead6b2
msfjarvis added a commit to fmeum/Android-Password-Store that referenced this issue Jul 14, 2020
@msfjarvis
Merge branch 'develop' into fhenneke_sshj_keystore
89a9401 
* develop: (77 commits)
  Add debug icon and update color palette (android-password-store#931)
  Revert "Work around Chrome Autofill issue (android-password-store#921)" (android-password-store#933)
  github: remove freeDebug variant from pull request matrix (android-password-store#932)
  Properly guard against invalid renaming (android-password-store#929)
  Fix navigation bar theming and reformat (android-password-store#930)
  Exclude third_party scope from reformats (android-password-store#927)
  Move password export to the IO dispatcher (android-password-store#918)
  Mention android-password-store#482 being fixed in the changelog (android-password-store#925)
  global: set an import order rule and reformat with it (android-password-store#924)
  styles: re-add alertDialogTheme override (android-password-store#923)
  Work around Chrome Autofill issue (android-password-store#921)
  Major UI overhaul and the introduction of a new icon (android-password-store#920)
  Update Public Suffix List data (android-password-store#917)
  Migrate to ActivityResultContracts (android-password-store#910)
  release: script improvements (android-password-store#915)
  Deploy both variants to snapshot directory (android-password-store#914)
  Fill OTP fields with SMS codes (android-password-store#900)
  Fix up URIish instances with @ in user name (android-password-store#913)
  build: upgrade Gradle wrapper (android-password-store#911)
  Scroll to files and enter folders when created (android-password-store#909)
  ...

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@zanona
Copy link

zanona commented Nov 5, 2020 •
edited
Loading

I'm not sure if this is related as this is related to the git repository authentication, but, by having my primary key + authentication subkey A on a smartcard and then, another authentication subkey B (generated by the same primary key), stored on my device, causes an issue where only subkey A is attempted while subkey B never gets tried. Unless I subkey A is removed.
It probably has to do with the fact that the prompt allows you to select a primary key instead of a specific authentication key.

@msfjarvis
Copy link
Member

I'm not sure if this is related, by having my primary key + authentication subkey A on a smartcard and then, another authentication subkey B (generated by the same primary key), stored on my device, causes an issue where only subkey A is attempted while subkey B never gets tried. Unless I subkey A is removed.

Being tracked at #998 alongside other key handling semantics where GnuPG and OpenKeychain differ from each other.

@zanona
Copy link

zanona commented Nov 5, 2020

Sorry, @msfjarvis, I realised I forgot to mention this is about the git repository authentication using openkeychain, rather than the encryption process itself? The issue mentioned seemed to be linked to issues around .gpg-id instead?
Perhaps this would be a better fit under a different issue?

@msfjarvis
Copy link
Member

Sorry, @msfjarvis, I realised I forgot to mention this is about the git repository authentication using openkeychain, rather than the encryption process itself? The issue mentioned seemed to be linked to issues around .gpg-id instead?
Perhaps this would be a better fit under a different issue?

Yeah please file a separate issue.

@zanona zanona mentioned this issue Nov 5, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@msfjarvis msfjarvis

Labels
None yet
Projects
None yet
Milestone
1.10.0
Development

No branches or pull requests
5 participants
@zanona @Radtoo @zeapo @msfjarvis @dsmaynard