This repository was archived by the owner on Oct 15, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 293
Add initial implementation of Gopenpgp-backed PGP #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ae83af4
to
507b3d2
Compare
TODO for myself
|
62ad397
to
fb6e07c
Compare
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Closed
I'm going to mark this as ready for review since the code here is basically done until #1446 is complete, which'll take some time. To test this, you'll have to hard-code your PGP private key and passphrase at the bottom of |
Skrilltrax
reviewed
Jul 11, 2021
crypto-pgp/src/main/kotlin/dev/msfjarvis/aps/data/crypto/GopenpgpCryptoHandler.kt
Outdated
Show resolved
Hide resolved
Skrilltrax
approved these changes
Jul 11, 2021
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A-PGP
Area: OpenKeychain-backed PGP
A-UI-UX
Area: General UI/UX concerns
C-feature
Category: This is a feature request
C-technical-debt
Category: This makes the code harder to read and modify, but has no impact on end users
E-medium
Effort: This requires a fair amount of work
P-high
Priority: high, must be resolved before next major release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Adds alternate implementations of GPG-handling activities which use Gopenpgp, and a simple feature flag to prevent this code from being exposed end users of snapshots.
💡 Motivation and Context
Work towards #1195
The intent of this PR is to demonstrate viability, and little more. It has no immediate benefits to users, and only serves to create an MVP that must be reworked as and when we start implementing new supporting functionality.
💚 How did you test it?
Verified with hard-coded credentials that encryption and decryption work.
📝 Checklist
./gradlew spotlessApply
🔮 Next steps