This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 281
Switch new PGP backend to use PGPainless #1522
Merged
msfjarvis
merged 12 commits into
android-password-store:develop
from
msfjarvis:pgpainless-backend
Oct 23, 2021
Merged
Switch new PGP backend to use PGPainless #1522
msfjarvis
merged 12 commits into
android-password-store:develop
from
msfjarvis:pgpainless-backend
Oct 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> (cherry picked from commit 02d07e9)
msfjarvis
added
C-technical-debt
Category: This makes the code harder to read and modify, but has no impact on end users
P-high
Priority: high, must be resolved before next major release
S-waiting-on-review
Status: This pull request has been implemented and needs to be reviewed
A-PGP
Area: OpenKeychain-backed PGP
labels
Oct 23, 2021
12 tasks
Skrilltrax
approved these changes
Oct 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A-PGP
Area: OpenKeychain-backed PGP
C-technical-debt
Category: This makes the code harder to read and modify, but has no impact on end users
P-high
Priority: high, must be resolved before next major release
S-waiting-on-review
Status: This pull request has been implemented and needs to be reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Implements a new crypto backend based on PGPainless, a BouncyCastle-backed, pure-Java library for OpenPGP that irons out a lot of the warts with other PGP libraries and is in active maintenance.
💡 Motivation and Context
While Gopenpgp is great in of itself, it has certain characteristics that make it rather undesirable for us.
PGPainless gets rid of all these problems:
Additionally, it leverages strong typing to entirely prevent multiple bug classes such as using a private and public key interchangeably.
Once this PR is merged I will archive our fork of Gopenpgp.
💚 How did you test it?
Inserted hard-coded credentials and verified decryption/encryption works perfectly.
📝 Checklist
./gradlew spotlessApply
🔮 Next steps