[Jetcaster] Handling no podcast selected and extracting state for home #1309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
arriolac
force-pushed
the
chris/jetcaster/ui_polish
branch
from
30ac31b to
4a9ab77
Compare
Base automatically changed from
chris/jetcaster/ui_polish
to
jetcaster/all_form_factors
April 2, 2024 16:40
mlykotom
approved these changes
Apr 2, 2024
| val filterableCategoriesModel: FilterableCategoriesModel, | ||
| val podcastCategoryFilterResult: PodcastCategoryFilterResult, | ||
| val library: LibraryInfo, | ||
| val modifier: Modifier = Modifier, |
There was a problem hiding this comment.
I think the state shouldn't contain modifier, because it's also passed to the HomeScreen composable.
| } | ||
|
|
||
| val homeState = HomeState( | ||
| windowSizeClass = windowSizeClass, |
There was a problem hiding this comment.
NIT: could be simplified by having just isCompact: Boolean, which would also potentially recompose less when changing the window size
florina-muntenescu
force-pushed
the
fm/jetcaster/no_selection
branch
from
fd75a1e to
bafdca3
Compare
arriolac
added a commit
that referenced
this pull request
Apr 3, 2024
#1313) Cherry picked changes from #1309 by @florina-muntenescu but fixing CLA issue. Closes #1309
|
Closed by #1313 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.