Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jetcaster] Optimize padding calculation by removing BoxWithConstraints #1514

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+26 −32
Open

[Jetcaster] Optimize padding calculation by removing BoxWithConstraints #1514

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33c4f60
Optimize padding calculation by removing BoxWithConstraints
yongsuk44 Nov 25, 2024
b956abd
Spotless apply
yongsuk44 Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 26 additions & 32 deletions Jetcaster/mobile/src/main/java/com/example/jetcaster/ui/home/Home.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.BoxScope
import androidx.compose.foundation.layout.BoxWithConstraints
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.PaddingValues
import androidx.compose.foundation.layout.Row
Expand Down Expand Up @@ -93,6 +92,7 @@ import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.clip
import androidx.compose.ui.geometry.Rect
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.platform.LocalConfiguration
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.style.TextOverflow
import androidx.compose.ui.tooling.preview.Preview
Expand Down Expand Up @@ -664,37 +664,31 @@ private fun FollowedPodcasts(
navigateToPodcastDetails: (PodcastInfo) -> Unit,
modifier: Modifier = Modifier,
) {
// TODO: Using BoxWithConstraints is not quite performant since it requires 2 passes to compute
// the content padding. This should be revisited once a carousel component is available.
// Alternatively, version 1.7.0-alpha05 of Compose Foundation supports `snapPosition`
// which solves this problem and avoids this calculation altogether. Once 1.7.0 is
// stable, this implementation can be updated.
BoxWithConstraints(
modifier = modifier.background(Color.Transparent)
) {
val horizontalPadding = (this.maxWidth - FEATURED_PODCAST_IMAGE_SIZE_DP) / 2
HorizontalPager(
state = pagerState,
contentPadding = PaddingValues(
horizontal = horizontalPadding,
vertical = 16.dp,
),
pageSpacing = 24.dp,
pageSize = PageSize.Fixed(FEATURED_PODCAST_IMAGE_SIZE_DP)
) { page ->
val podcast = items[page]
FollowedPodcastCarouselItem(
podcastImageUrl = podcast.imageUrl,
podcastTitle = podcast.title,
onUnfollowedClick = { onPodcastUnfollowed(podcast) },
lastEpisodeDateText = podcast.lastEpisodeDate?.let { lastUpdated(it) },
modifier = Modifier
.fillMaxSize()
.clickable {
navigateToPodcastDetails(podcast)
}
)
}
val screenWidthDp = LocalConfiguration.current.screenWidthDp.dp
val horizontalPadding = (screenWidthDp - FEATURED_PODCAST_IMAGE_SIZE_DP) / 2

HorizontalPager(
state = pagerState,
contentPadding = PaddingValues(
horizontal = horizontalPadding,
vertical = 16.dp,
),
pageSpacing = 24.dp,
pageSize = PageSize.Fixed(FEATURED_PODCAST_IMAGE_SIZE_DP),
modifier = modifier,
) { page ->
val podcast = items[page]
FollowedPodcastCarouselItem(
podcastImageUrl = podcast.imageUrl,
podcastTitle = podcast.title,
onUnfollowedClick = { onPodcastUnfollowed(podcast) },
lastEpisodeDateText = podcast.lastEpisodeDate?.let { lastUpdated(it) },
modifier = Modifier
.fillMaxSize()
.clickable {
navigateToPodcastDetails(podcast)
}
)
}
}

Expand Down