Skip to content

Conversation

JolandaVerhoef
Copy link
Collaborator

This commit replaces all usages of androidx.compose.material.icons with equivalent drawable resources. This change is applied across the mobile, wear, and tv modules.

The primary motivation for this change is to reduce the dependency on the androidx.compose.material.icons library and to provide more explicit control over the visual assets used in the application.

Specific changes include:

  • Removing dependencies on androidx.material.icons.core and androidx.compose.material.iconsExtended from build.gradle files.
  • Replacing ImageVector instances (e.g., Icons.Default.Check, Icons.AutoMirrored.Filled.PlaylistAdd) with painterResource(id = R.drawable.*) calls in various Composable functions.
  • Adding new XML drawable resources for icons that were previously sourced from the Material Icons library. These include icons such as ic_add.xml, ic_remove.xml, ic_play_arrow.xml, ic_pause.xml, etc.
  • Updating ButtonWithIcon composable in the tv module to accept a @DrawableRes iconId: Int instead of an ImageVector.
  • Minor cleanup in Jetcaster/mobile/src/main/res/drawable/genres.xml by removing the android:tint attribute.
  • Minor cleanup in Jetcaster/mobile/src/main/res/values/strings.xml by removing an extra space.

This commit replaces all usages of `androidx.compose.material.icons` with
equivalent drawable resources. This change is applied across the `mobile`,
`wear`, and `tv` modules.

The primary motivation for this change is to reduce the dependency on the
`androidx.compose.material.icons` library and to provide more explicit
control over the visual assets used in the application.

Specific changes include:
- Removing dependencies on `androidx.material.icons.core` and
`androidx.compose.material.iconsExtended` from `build.gradle` files.
- Replacing `ImageVector` instances (e.g., `Icons.Default.Check`,
`Icons.AutoMirrored.Filled.PlaylistAdd`) with `painterResource(id = R.drawable.*)`
calls in various Composable functions.
- Adding new XML drawable resources for icons that were previously sourced
from the Material Icons library. These include icons such as `ic_add.xml`,
`ic_remove.xml`, `ic_play_arrow.xml`, `ic_pause.xml`, etc.
- Updating `ButtonWithIcon` composable in the `tv` module to accept a
`@DrawableRes iconId: Int` instead of an `ImageVector`.
- Minor cleanup in `Jetcaster/mobile/src/main/res/drawable/genres.xml` by
removing the `android:tint` attribute.
- Minor cleanup in `Jetcaster/mobile/src/main/res/values/strings.xml` by
removing an extra space.
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @JolandaVerhoef, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring of the application's icon system. The primary goal is to reduce reliance on the androidx.compose.material.icons library by replacing its usage with custom drawable resources. This change provides greater control over visual assets and streamlines the icon management across the mobile, wear, and tv modules.

Highlights

  • Dependency Reduction: Removed direct dependencies on androidx.compose.material.icons.core and androidx.compose.material.iconsExtended across the mobile, wear, and tv modules, reducing the application's external library footprint.
  • Icon System Refactor: Replaced all instances of ImageVector (e.g., Icons.Default.Check) with painterResource(id = R.drawable.*) calls in Composable functions, standardizing icon usage to local drawable resources.
  • New Drawable Resources: Introduced a comprehensive set of new XML drawable resources (e.g., ic_add.xml, ic_play_arrow.xml) to provide custom icons that were previously sourced from the Material Icons library.
  • API Adaptation in TV Module: Modified the ButtonWithIcon composable in the tv module to accept a @DrawableRes iconId: Int instead of an ImageVector, aligning its API with the new drawable-based icon approach.
  • Minor Code Cleanups: Performed small cleanups, including removing the android:tint attribute from Jetcaster/mobile/src/main/res/drawable/genres.xml and an extra space in Jetcaster/mobile/src/main/res/values/strings.xml.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This is a great refactoring to remove the dependency on material-icons-extended and switch to local drawable resources. The changes are extensive and well-executed across the mobile, tv, and wear modules.

I've found a couple of minor issues with incorrect icon replacements that affect UI correctness. Please take a look at my comments. Once those are addressed, this PR should be good to go.

Great work on this large-scale cleanup!

@JolandaVerhoef JolandaVerhoef marked this pull request as ready for review July 4, 2025 14:04
@JolandaVerhoef JolandaVerhoef requested a review from a team as a code owner July 4, 2025 14:04
@JolandaVerhoef JolandaVerhoef requested review from simona-anomis and riggaroo and removed request for simona-anomis July 4, 2025 14:04
@JolandaVerhoef JolandaVerhoef changed the title Refactor: Replace Material Icons with drawable resources [Jetcaster] Replace Material Icons with drawable resources Jul 4, 2025
@JolandaVerhoef JolandaVerhoef merged commit 1fbc2c2 into main Jul 4, 2025
2 checks passed
@JolandaVerhoef JolandaVerhoef deleted the jv/jetcaster-new-icons branch July 4, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants