Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samples to latest library versions #68

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Conversation

pfmaggi
Copy link
Contributor

@pfmaggi pfmaggi commented Jan 14, 2025

  • Switch Gradle syntax to KTS
  • Update library version
  • Support edge-to-edge
  • Update github workflow
  • Update gradlew and gradlew.bat files

@pfmaggi pfmaggi requested a review from JoseAlcerreca January 14, 2025 16:11
distributionPath=wrapper/dists
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-bin.zip

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update gradlew too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

includeGroupByRegex("com\\.android.*")
includeGroupByRegex("com\\.google.*")
includeGroupByRegex("androidx.*")
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt this is necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's coming from the current template in Android Studio (Ladybug Feature Drop | 2024.2.2).

@pfmaggi pfmaggi merged commit b2791a4 into android:main Jan 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants