-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Migrate all samples to RegisterNatives.
#1152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3cf49f4 to
759fa23
Compare
|
at least for the cases where this is adding more lines of boilerplate than there is of actual code, is there some motivation we can add to the commit message? |
There are 18 commit messages, but I suppose I can go edit all of them. Alternatively, I've been thinking that I should probably add a doc (maybe just in the readme) that explains some of the best practices we're aiming to show. I can add another commit that adds that language instead, though I may do that in a separate PR if that's alright, since I suspect I'll need some feedback from you to nail down exactly what to say about this particular practice. I'm not an expert at JNI, but I am apparently an expert at internalizing the message of your rants without always remembering your reasons 😆 |
b642f36 to
62e8153
Compare
Done #1153 |
|
(approved anyway since this isn't wrong, even if it's not what i'd do [except maybe for the more complicated examples]...) |
Oh, and there's the answer to my question earlier. I'd overlooked this comment :) |
No description provided.