-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--fix-cortex-a8 for lld #766
Comments
With ndk18 beta 1, armv7a and -fuse-ld=lld i had to add to get rid ot that (it was added by default by cmake toolchain) string(REPLACE "-Wl,--fix-cortex-a8" "" CMAKE_SHARED_LINKER_FLAGS ${CMAKE_SHARED_LINKER_FLAGS}) |
It's also in ndk-build and standalone toolchains. For the latter two we can check the user's ldflags to see if they're using lld, but for CMake we don't have that information yet (the CMakeLists.txt hasn't been parsed that early). Would be a good candidate for hoisting into the driver. It may already have been, actually. I'll check. |
Finally got the data we need. There are an insignificant number of devices in the API range supported by the NDK that use Cortex-A8 CPUs, so we'll drop that from the default flags and mention it in the changelog with a link to CPU blacklisting like we did for NEON. Closing this bug in favor of #776 to handle actually removing the flag from the defaults. |
…n WSL (#1744) * Fix libffi linker errors when compiling on WSL Optional use of lld (LLVM's linker), and include a python37 bugfix. https://clang.llvm.org/docs/Toolchain.html https://lld.llvm.org/ https://bz-attachments.freebsd.org/attachment.cgi?id=200526 * Remove lld unsupported fix-cortex-a8 from LDFLAGS android/ndk#313 android/ndk#766 https://developer.android.com/ndk/guides/standalone_toolchain * Fix libffi recipe, runtime libffi linker errors. Libtool didnt like the space after --sysroot, replaced with = * CRAs - Check for lld before using it. Changed hardcoded cpu count to cpu_count(). Added comment to python patch. Made remove-fix-cortex-a8.patch conditional on lld. Moved LDFLAGS change to get_recipe_env() so its not libffi specific within python.py.
This flag isn't supported by LLD and appears to not be pased from r18 onwards: android/ndk#766
Do we still need to support fixing this errata? Still waiting on data...
The text was updated successfully, but these errors were encountered: