Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable animations of instrumented tests #1167

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

SimonMarquis
Copy link
Contributor

@JoseAlcerreca
Copy link
Contributor

This is already done by the disable-animations parameter in the action, which is true by default. Any reason to do it here as well?

@SimonMarquis
Copy link
Contributor Author

This will only work when running on CI with reactivecircus/android-emulator-runner, but if devs are running instrumented tests locally (they should), the animations on their devices won't be disabled unless configured.

@SimonMarquis
Copy link
Contributor Author

@JoseAlcerreca does my answer makes sense for this project or should I discard this PR?

@JoseAlcerreca
Copy link
Contributor

Good point!

@JoseAlcerreca JoseAlcerreca merged commit ab90334 into android:main Mar 6, 2024
4 checks passed
dturner added a commit that referenced this pull request Mar 6, 2024
* main: (37 commits)
  Disable animations of instrumented tests (#1167)
  Bump gradle/wrapper-validation-action from 1 to 2
  Remove unused release variable. Fixes #1231
  Apply Composable Parameter Ordering Guidelines
  Remove kotlinx-coroutines-guava dependency from :sync:work
  Add explicit guava-android dependency for :sync:work
  Extract ScreenshotHelper to separate testing module
  Update AGP to 8.3.0
  Remove Insert function - Insert is only used in test. - Upsert do same thing as Insert.
  🤖 Updates baselines for Dependency Guard
  Bump the kotlin-ksp-compose group with 6 updates
  🤖 Updates baselines for Dependency Guard
  Bump hilt from 2.50 to 2.51
  Bump com.google.truth:truth from 1.1.5 to 1.4.2
  Move java to kotlin folder.
  Remove disk usage testing
  Figuring out what is using 66Gb in the runner
  Dpm
  Improve converting to kotlin timezone
  Use trySend multiple times
  ...

Change-Id: If3f564108d42675ba55ef242f0d06f04aff45c4a
dturner added a commit that referenced this pull request Mar 6, 2024
* main: (37 commits)
  Disable animations of instrumented tests (#1167)
  Bump gradle/wrapper-validation-action from 1 to 2
  Remove unused release variable. Fixes #1231
  Apply Composable Parameter Ordering Guidelines
  Remove kotlinx-coroutines-guava dependency from :sync:work
  Add explicit guava-android dependency for :sync:work
  Extract ScreenshotHelper to separate testing module
  Update AGP to 8.3.0
  Remove Insert function - Insert is only used in test. - Upsert do same thing as Insert.
  🤖 Updates baselines for Dependency Guard
  Bump the kotlin-ksp-compose group with 6 updates
  🤖 Updates baselines for Dependency Guard
  Bump hilt from 2.50 to 2.51
  Bump com.google.truth:truth from 1.1.5 to 1.4.2
  Move java to kotlin folder.
  Remove disk usage testing
  Figuring out what is using 66Gb in the runner
  Dpm
  Improve converting to kotlin timezone
  Use trySend multiple times
  ...

Change-Id: If3f564108d42675ba55ef242f0d06f04aff45c4a
@SimonMarquis SimonMarquis deleted the disable-animations branch March 6, 2024 09:20
dturner added a commit that referenced this pull request Mar 6, 2024
* main: (37 commits)
  Disable animations of instrumented tests (#1167)
  Bump gradle/wrapper-validation-action from 1 to 2
  Remove unused release variable. Fixes #1231
  Apply Composable Parameter Ordering Guidelines
  Remove kotlinx-coroutines-guava dependency from :sync:work
  Add explicit guava-android dependency for :sync:work
  Extract ScreenshotHelper to separate testing module
  Update AGP to 8.3.0
  Remove Insert function - Insert is only used in test. - Upsert do same thing as Insert.
  🤖 Updates baselines for Dependency Guard
  Bump the kotlin-ksp-compose group with 6 updates
  🤖 Updates baselines for Dependency Guard
  Bump hilt from 2.50 to 2.51
  Bump com.google.truth:truth from 1.1.5 to 1.4.2
  Move java to kotlin folder.
  Remove disk usage testing
  Figuring out what is using 66Gb in the runner
  Dpm
  Improve converting to kotlin timezone
  Use trySend multiple times
  ...

Change-Id: If3f564108d42675ba55ef242f0d06f04aff45c4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants