Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Dropshots and edge-to-edge tests #1459

Draft
wants to merge 71 commits into
base: main
Choose a base branch
from
Draft

Adds Dropshots and edge-to-edge tests #1459

wants to merge 71 commits into from

Conversation

JoseAlcerreca
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.81% ❌

There is no coverage information present for the Files changed

@JoseAlcerreca JoseAlcerreca force-pushed the ja/edge-to-edge-dropshots branch 2 times, most recently from 1adb04a to a14b142 Compare May 24, 2024 13:11
@android android deleted a comment from github-actions bot May 24, 2024
@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.75% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.78% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.74% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.77% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.74% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.81% ❌

There is no coverage information present for the Files changed

@JoseAlcerreca JoseAlcerreca force-pushed the ja/edge-to-edge-dropshots branch from 3469045 to dac5b22 Compare May 27, 2024 12:45
@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.78% ❌

There is no coverage information present for the Files changed

@JoseAlcerreca JoseAlcerreca force-pushed the ja/edge-to-edge-dropshots branch from 98f8c0c to a6a15ef Compare May 27, 2024 13:59
@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.81% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.77% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.81% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.78% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.75% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.81% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.77% ❌

There is no coverage information present for the Files changed

1 similar comment
@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.77% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 41.41% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 41.4% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 41.38% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 41.37% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 41.4% 🍏

There is no coverage information present for the Files changed

2 similar comments
@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 41.4% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 41.4% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

Combined test coverage report

Overall Project 41.37% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Combined test coverage report

Overall Project 41.4% 🍏

There is no coverage information present for the Files changed

@JoseAlcerreca
Simplify if clause
d4093a5 
Change-Id: I52bd1c0755e56e7357a2b49952cf813b9d8fdf97
@JoseAlcerreca
The action does some script parsing that is breaking the if clause, l…
4c79213 
…ets try single line

Change-Id: Icfd4a6fd945393b434c3eb171ddaee376459b0e9
@JoseAlcerreca
Script in single line
ee7556f 
Change-Id: I41223f4d777747c55c586bb8d2aecd86db21d85f
@JoseAlcerreca
Pixel fold is google_apis
ad5dc1b 
Change-Id: I0840f2c8fac16d59bc42ed62a1033438c1b4b3b0
@JoseAlcerreca
Adds target
1160b88 
Change-Id: I225ce5b4e28564a05754b9230fb175b5c91c9e14
@JoseAlcerreca
no google_apis for api 27
0005c1b 
Change-Id: I87df5cc139d25bee28070306983f16fbbd270fb4
@JoseAlcerreca
There is a flaky test but the step should not pass
fde23a4 
Change-Id: I0de92c500ecdf1029d0a11c505b41df7ea3ec042
@JoseAlcerreca
Now we can comment out the flaky test
8ff1ac5 
Change-Id: Ifc041931bcf47e8716dcbe1e8c13617c88c932ea
@JoseAlcerreca
Removes espresso device
d75d4f0 
Change-Id: I5c32f70dad7dc27c98c34733f3fd80c71ccb773a
@JoseAlcerreca
Restrict screenshot tests to :app
5ddcba5 
Change-Id: I96dc5df1fccac71c42fb0e87997969bdf7b2d5f3
@JoseAlcerreca
Weird emulator issues, joy
96dd9dc 
Change-Id: Ie042a4ff74185279c4b42016261ce94757a5bee9
@JoseAlcerreca
Trying again with two emulator steps
175bb21
@JoseAlcerreca
Trying again with two emulator steps
b4f9e0d
@JoseAlcerreca
Debug hell
39c1bb4
@JoseAlcerreca
Debug hell
dee3bdb
@JoseAlcerreca
Debug hell
f8f80e8
@JoseAlcerreca
Debug hell
b2ad870
@JoseAlcerreca
Debug hell
d16ed17
@JoseAlcerreca
Runner hangs when launching emulator for the second time, trying new …
2b28127 
…memory args
@JoseAlcerreca
SHAME! I added an infinite loop
19edb84 
Change-Id: I60a019523ff703dfdda3ea0c16b052525412eb8d
@JoseAlcerreca
Fixed! Except for API 35, uploading logcat
2323822 
Change-Id: I689a9a6b1204df6c297704b6214a7ebb280d2d57
@JoseAlcerreca
Cutout tests, working locally. Need to rebase
e26492a 
Change-Id: Ib3e4dc2c62bbdd89bfd6380a33310e3033a58966
@JoseAlcerreca
Some more sync points, api 35 emulator crashing
0191ba0 
Change-Id: I90422a13aaba689b035095307446d7d343a59aed
@JoseAlcerreca JoseAlcerreca force-pushed the ja/edge-to-edge-dropshots branch from 7bfaf82 to 0191ba0 Compare June 6, 2024 13:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

Combined test coverage report

Overall Project 41.4% 🍏

There is no coverage information present for the Files changed

@JoseAlcerreca
Copy link
Contributor Author

Update: Works pretty well although synchronization is done in a hacky way, possibly. Looking into better ways to do it.

Also, VanillaIceCream emulator is simply crashing and the step is not failing for some reason.

Jaehwa-Noh
Jaehwa-Noh reviewed Jun 11, 2024
View reviewed changes
app/src/androidTest/screenshots/edgeToEdge_Foldable_closed_system_api33.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a real device?
Why I can see the charge icon?

@keyboardsurfer
Copy link
Member

Thanks for your PR. Currently there are conflicts that need to be resolved before we can move on to possibly accepting your contribution. Please resolve the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaehwa-Noh Jaehwa-Noh Jaehwa-Noh left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoseAlcerreca @keyboardsurfer @Jaehwa-Noh