TestFixtures refactoring #1515
Open
TestFixtures refactoring #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonMarquis
force-pushed
the
test-fixtures-agp-8.5.0
branch
from
8f377a3 to
35adf5e
Compare
This was referenced Jun 23, 2024
|
This PR has a lot of conflicts. Do you want to continue and resolve these, @SimonMarquis ? |
|
@keyboardsurfer yes, I'd love to see this integrated in the repository at some point (the initial PoC was on Nov 19, 2022 😅). |
|
Good to hear that you're interested in picking this back up again. @JoseAlcerreca can you chime in on the likelihood of this PR being integrated into main? |
|
Just to add my 2 pence, I am strongly in favour of anything that tidies up our test architecture and TestFixtures seems to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Kotlin TestFixtures on Android modules was added in AGP 8.5.0!
A lot more cleanup could be done, especially on test classes that redefine over and over again topics, newsResources, etc.
This is a new take on this PR:
To close this issue from 2022:
The main changes are split by commits:
enableTestFixturesKotlinSupportflag:core:data-test,:sync:testand:core:datastore-testhave been merged as testFixtures sourceSet of their respective module.:core:testingcontent has been migrated when possible to already existing modules.:sync:workhas been move to it's parent:syncmodule that was previously empty.android.experimental.enableTestFixturesKotlinSupportto promote from experimental?