Use jemalloc in CI #1643
Closed
Use jemalloc in CI #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@javadude Would you be able to review this please? |
|
@dturner Was this in response to a bug (were CI builds failing?), or do we want to add it as a recommendation? |
|
Having discussed this with @javadude we've concluded that unfortunately we can't accept this PR. The reason is that it adds complexity to our build in an area which we don't have expertise in. If it fails, there'll be no-one to fix it. |
|
If Gradle supported it as an option in their build action would that be viable? I understand and agree with the reasoning, I'd just like to find a way forward for the Android community that works well. |
|
Possibly (and it sounds like it could be quite useful). |
|
Closing this one; if you can get this integrated with Gradle feel free to open a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have done and why
In this PR I want to add jemalloc to the GitHub CI as that should give roughly 10% memory savings by fixing native memory fragmentation. I did this through a custom action that caches jemalloc.
You can see in Inaki's blog post about jemalloc for Gradle Android builds that these significant savings are reproducible and worthwhile considering the very small change needed.