Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update screenshot dependencies including robolectric, roborazzi #1699

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

yschimke
Copy link
Contributor

@yschimke yschimke commented Nov 17, 2024

Update Compose BOM to 2024.11.00 and update other dependencies, such as Robolectric and Roborazzi.

There have been a bunch of useful fixes in Compose, Robolectric and Roborazzi, so move towards these.

The motivation is I'd like to start using some extra roborazzi features and want to decouple this from functionality changes.

@yschimke yschimke changed the title Update dependencies Update screenshot dependencies Nov 17, 2024
@yschimke yschimke changed the title Update screenshot dependencies Update screenshot dependencies including robolectric, roborazzi, running on API 35 Nov 17, 2024
@yschimke yschimke marked this pull request as ready for review November 17, 2024 18:49
@yschimke
Copy link
Contributor Author

yschimke commented Nov 17, 2024

Updating screenshots on a fork PR yschimke#1

@yschimke yschimke marked this pull request as draft November 17, 2024 19:07
@yschimke yschimke marked this pull request as ready for review November 17, 2024 19:22
@yschimke yschimke changed the title Update screenshot dependencies including robolectric, roborazzi, running on API 35 Update screenshot dependencies including robolectric, roborazzi Nov 18, 2024
Update Compose BOM to 2024.11.00 and update other dependencies, such as Robolectric and Roborazzi.
Also, update Screenshot Tests with sdk version 35 for better screenshot testing.
@yschimke yschimke marked this pull request as draft November 18, 2024 09:53
@yschimke yschimke marked this pull request as ready for review November 18, 2024 11:26
@yschimke
Copy link
Contributor Author

@SimonMarquis good call, the text changes are gone by sticking with the same sdk.

@dturner
Copy link
Collaborator

dturner commented Nov 18, 2024

The Compose BOM bump from 2024.09.00 to 2024.10.01 is what is causing the screenshot changes. This is caused by aosp/3317353.

Happy for these to be merged since there are no obvious changes to the UI.

@dturner dturner self-requested a review November 18, 2024 15:32
@yschimke yschimke merged commit 717f2db into android:main Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants