Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency graphs to every module #310

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Conversation

mmoczkowski
Copy link
Contributor

Closes #180

Change-Id: I629fef818f7521c13bb3069a3ff9ed9bc42e57f3
@dturner
Copy link
Collaborator

dturner commented Sep 30, 2022

First, this is incredible!

Second, nit: could we make the images smaller so they're easier to see on a single screen?

Copy link
Collaborator

@dturner dturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smaller images please, otherwise LGTM

Change-Id: I942180c28c471193d2ed3ed76461a1d76d8a93f2
@mmoczkowski
Copy link
Contributor Author

Hey @dturner, I made the graphs smaller. Let me know if they need further adjustments!

@dturner dturner merged commit 6351a89 into main Oct 4, 2022
@RicardoJiang
Copy link

RicardoJiang commented Oct 9, 2022

May I ask , Are these images drawn manually or automatically generated? @mmoczkowski

@mmoczkowski
Copy link
Contributor Author

May I ask , Are these images drawn manually or automatically generated? @mmoczkowski

Hey, those were generated by a plugin. I'm planning to open source it at some point. Do you find the graphs useful?

@RicardoJiang
Copy link

May I ask , Are these images drawn manually or automatically generated? @mmoczkowski

Hey, those were generated by a plugin. I'm planning to open source it at some point. Do you find the graphs useful?

I think the graphs are beautiful and easy to understand, but each diagram only includes the direct dependencies of the module(After all, We can see the direct dependencies of the current module directly in build.gradle)

people may prefer to see the overall structure of the project, but this makes the graphs complicated and difficult to understand, I think It's hard to choose between the two

All in all, looking forward to your open source plugin, good job

@yoonseopshin
Copy link

@mmoczkowski
🙏🏼 🙏🏼 🙏🏼

@mtzhisham
Copy link

May I ask , Are these images drawn manually or automatically generated? @mmoczkowski

Hey, those were generated by a plugin. I'm planning to open source it at some point. Do you find the graphs useful?

Hey @mmoczkowski, I think it's very helpful to generate these graphs from onboarding new developers to getting to maintain modules with respect to their dependencies, can't wait to try the plugin.

@miduch
Copy link

miduch commented Nov 17, 2022

can't wait to try the plugin.

+1

@mmoczkowski 🙏🏼

@miduch
Copy link

miduch commented Nov 23, 2022

@mmoczkowski can you give any rough ETA when this plugin is open source? if this isn't going to happen in near future would you be able to give some guidelines to try create own? Thanks!

@niusounds
Copy link

I also want to use the plugin!

@madroidmaq
Copy link
Contributor

May I ask , Are these images drawn manually or automatically generated? @mmoczkowski

Hey, those were generated by a plugin. I'm planning to open source it at some point. Do you find the graphs useful?

I think the graphs are beautiful and easy to understand, but each diagram only includes the direct dependencies of the module(After all, We can see the direct dependencies of the current module directly in build.gradle)

people may prefer to see the overall structure of the project, but this makes the graphs complicated and difficult to understand, I think It's hard to choose between the two

All in all, looking forward to your open source plugin, good job

@RicardoJiang I use Jake Wharton's projectDependencyGraph script generates a complete dependency graph of the project, the effect is roughly as follows, I hope it will help you

project dot

@nienienienie
Copy link

any update of the graph generator @mmoczkowski ?

@amineharbaouibnp
Copy link

@mmoczkowski any news about this graph plugin please ? we really look forward to try it, it will be a super useful tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Provide a graph of the module structure
10 participants