Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kotlin 1.8.20 stack #666

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Conversation

SimonMarquis
Copy link
Contributor

@SimonMarquis SimonMarquis commented Apr 16, 2023

  • KSP 1.8.20-1.0.11
  • Compose compiler 1.4.5

This needs JDK 17, and therefore applied on top of #662.

Also, we might want to wait for the next KSP version with this fix google/ksp#1280
Otherwise we get errors like this if KSP uses the build-cache.
fixed in 1.8.20-1.0.11

Copy link
Collaborator

@dturner dturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. LGTM.

@SimonMarquis SimonMarquis force-pushed the update/kotlin-1.8.20 branch from dc64dbe to 4d311f2 Compare April 26, 2023 17:59
@SimonMarquis
Copy link
Contributor Author

SimonMarquis commented Apr 26, 2023

I rebased my changes to make it cleaner now that AGP 8 is merged,

@SimonMarquis SimonMarquis changed the title Update Kotlin 1.8.20 stack Update Kotlin 1.8.21 stack Apr 26, 2023
- KSP 1.8.20-1.0.10
- Compose compiler 1.4.5
@SimonMarquis SimonMarquis force-pushed the update/kotlin-1.8.20 branch from 4d311f2 to 5500edc Compare April 26, 2023 18:26
@SimonMarquis SimonMarquis changed the title Update Kotlin 1.8.21 stack Update Kotlin 1.8.20 stack Apr 26, 2023
@alexvanyo alexvanyo self-requested a review April 26, 2023 20:06
@dturner dturner merged commit 70b9c4c into android:main Apr 28, 2023
@SimonMarquis SimonMarquis deleted the update/kotlin-1.8.20 branch April 28, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incremental compilation fails with "Number of loaded files in snapshots differs"
3 participants