Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #849: Loading progress for image #850

Merged
merged 25 commits into from
Aug 12, 2023
Merged

Fix #849: Loading progress for image #850

merged 25 commits into from
Aug 12, 2023

Conversation

qamarelsafadi
Copy link
Contributor

@qamarelsafadi qamarelsafadi commented Jul 22, 2023 •
edited
Loading

What?

Fixes #849

Why?

This pull request addresses an enhancement for showing loading progress while the Image is showing

How?

To make this enhancement I had to check the status of the Async Image if it is loading show a CirclularProgresBar which will disappear once the image is loaded and shown it.

after doing this the app looks on fire 🚀!

Screen.Recording.2023-07-22.at.12.07.03.PM.mov

This PR was submitted by a member of the GTC open source initiative

@SimonMarquis
Copy link
Contributor

I think this TODO can be removed:

https://github.com/qamarelsafadi/nowinandroid/blob/427d65ecb2e63a59a513dc0127633f290532c88a/feature/foryou/src/main/java/com/google/samples/apps/nowinandroid/feature/foryou/ForYouScreen.kt#L397

SimonMarquis
SimonMarquis reviewed Jul 29, 2023
View reviewed changes
Copy link
Contributor

@SimonMarquis SimonMarquis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, although we should confirm with the project maintainers if ic_placeholder_default should really be used by default for all DynamicAsyncImage.

@qamarelsafadi
Copy link
Contributor Author

👍 LGTM, although we should confirm with the project maintainers if ic_placeholder_default should really be used by default for all DynamicAsyncImage.

@dturner Could you please confirm this to us ?

@qamarelsafadi
Copy link
Contributor Author

👍 LGTM, although we should confirm with the project maintainers if ic_placeholder_default should really be used by default for all DynamicAsyncImage.

@tunjid Could you please confirm this for us?

@tunjid
Copy link
Contributor

tunjid commented Aug 11, 2023

@qamarelsafadi thank you so much for your changes. Do you mind updating your PR description to say "This PR was submitted by a member of the GTC open source initiative" instead?

@qamarelsafadi
Copy link
Contributor Author

qamarelsafadi commented Aug 11, 2023 •
edited
Loading

@qamarelsafadi thank you so much for your changes. Do you mind updating your PR description to say "This PR was submitted by a member of the GTC open source initiative" instead?

Done @tunjid

@tunjid tunjid merged commit 153b34f into android:main Aug 12, 2023
5 checks passed
@JoseAlcerreca
Copy link
Contributor

JoseAlcerreca commented Aug 18, 2023 •
edited
Loading

👍 LGTM, although we should confirm with the project maintainers if ic_placeholder_default should really be used by default for all DynamicAsyncImage.

Indeed, this broke previews and the new screenshot tests #876

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonMarquis SimonMarquis SimonMarquis left review comments

@tunjid tunjid tunjid approved these changes

@mtali mtali Awaiting requested review from mtali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR]: Show Loading progress while Image is showing
5 participants
@qamarelsafadi @SimonMarquis @tunjid @JoseAlcerreca @mtali