Update multiple-links snippet #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontent/support-multiple-links?hl=en (Multiple links in a text string) from deprecated pushStringAnnotation() to currently supported withLink().
…ontent/support-multiple-links?hl=en (Multiple links in a text string) from deprecated pushStringAnnotation() to currently supported withLink().
…ontent/support-multiple-links?hl=en (Multiple links in a text string) from deprecated pushStringAnnotation() to currently supported withLink().
…ontent/support-multiple-links?hl=en (Multiple links in a text string) from deprecated pushStringAnnotation() to currently supported withLink().
riggaroo
reviewed
Sep 20, 2024
Comment on lines
554
to
576
| Text( | ||
| buildAnnotatedString { | ||
| append("Build better apps faster with ") | ||
| append("Go to the ") | ||
| withLink( | ||
| LinkAnnotation.Url( | ||
| "https://developer.android.com/jetpack/compose", | ||
| "https://developer.android.com/", | ||
| TextLinkStyles(style = SpanStyle(color = Color.Blue)) | ||
| ) | ||
| ) { | ||
| append("Jetpack Compose") | ||
| append("Android Developers ") | ||
| pop() | ||
| append("website, and check out the") | ||
| } | ||
| withLink( | ||
| LinkAnnotation.Url( | ||
| "https://developer.android.com/jetpack/compose", | ||
| TextLinkStyles(style = SpanStyle(color = Color.Green)) | ||
| ) | ||
| ) { | ||
| append("Compose guidance") | ||
| pop() | ||
| append(".") | ||
| pop() |
There was a problem hiding this comment.
You dont need the pop operations here, just move the non-linked text out of the withLink() {} lambda.
Text(
buildAnnotatedString {
append("Go to the ")
withLink(
LinkAnnotation.Url(
"https://developer.android.com/",
TextLinkStyles(style = SpanStyle(color = Color.Blue))
)
) {
append("Android Developers ")
}
append("website, and check out the")
withLink(
LinkAnnotation.Url(
"https://developer.android.com/jetpack/compose",
TextLinkStyles(style = SpanStyle(color = Color.Green))
)
) {
append("Compose guidance")
}
append(".")
}
)
riggaroo
requested changes
Sep 20, 2024
…te-multiple-links # Conflicts: # compose/snippets/src/main/java/com/example/compose/snippets/text/TextSnippets.kt
Not sure what to do about this. |
fixed it for you |
riggaroo
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.