Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #174: Selecting Seekbar to move video time freezes controls #177

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

Geletinousamigo
Copy link
Contributor

  • This PR solves the issue caused due to removal of onActionUp(::invoke) from handleDPadKeyEvents Modifier extension fun.

  • Also when we first move the focus from play/pause button to VideoPlayerIndicator the focus is moved to right side again because of this condition, when the VideoPlayerIndicator is not selected then it should not override the onLeft and onRight behaviour, focus events are handled properly when the onLeft and onRight is not overrided

    onRight = {
        if (isSelected) {
             seekProgress = (seekProgress + 0.1f).coerceAtMost(1f)
       } else {
            focusManager.moveFocus(FocusDirection.Right)
       }
    }
  • Also removed the focusManager.moveFocus(FocusDirection.Exit) called on onSeek event, because the focus was lost from the screen, and came back only when play/pause button was focused again when overlay is visible again

Copy link

google-cla bot commented Jun 1, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@chikoski chikoski requested a review from JolandaVerhoef June 4, 2024 06:36
Copy link
Contributor

@chikoski chikoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for sending the pull request!

@chikoski chikoski merged commit 827d6e7 into android:main Jun 12, 2024
1 of 2 checks passed
@chikoski chikoski removed the request for review from JolandaVerhoef June 12, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants