refactor: apply suggestions from Android Studio

android · Jan 6, 2023 · 5020a44 · 5020a44
1 parent be49027
commit 5020a44
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 9 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -55,6 +55,7 @@ android {
             proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
         }
     }
+    namespace 'com.example.android.uamp'
 }
 
 dependencies {

diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
@@ -16,8 +16,7 @@
   -->
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:dist="http://schemas.android.com/apk/distribution"
-    xmlns:tools="http://schemas.android.com/tools"
-    package="com.example.android.uamp">
+    xmlns:tools="http://schemas.android.com/tools">
 
     <application
         android:allowBackup="true"

diff --git a/automotive/build.gradle b/automotive/build.gradle
@@ -52,6 +52,7 @@ android {
             proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
         }
     }
+    namespace 'com.example.android.uamp.automotive'
 
 }
 

diff --git a/automotive/src/main/AndroidManifest.xml b/automotive/src/main/AndroidManifest.xml
@@ -15,8 +15,7 @@
   -->
 
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    xmlns:tools="http://schemas.android.com/tools"
-    package="com.example.android.uamp.automotive">
+    xmlns:tools="http://schemas.android.com/tools">
 
     <!--
     Since this module contains code exclusive to Android Automotive, require the feature here.

diff --git a/common/build.gradle b/common/build.gradle
@@ -23,9 +23,6 @@ android {
     compileSdkVersion rootProject.compileSdkVersion
 
     defaultConfig {
-        versionCode 1
-        versionName "1.0"
-
         minSdkVersion rootProject.minSdkVersion
         targetSdkVersion rootProject.targetSdkVersion
 
@@ -42,6 +39,7 @@ android {
     compileOptions {
         targetCompatibility = '1.8'
     }
+    namespace 'com.example.android.uamp.media'
 
 }
 

diff --git a/common/src/main/AndroidManifest.xml b/common/src/main/AndroidManifest.xml
@@ -15,8 +15,7 @@
   ~ limitations under the License.
   -->
 
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    package="com.example.android.uamp.media">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android">
 
     <uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
     <uses-permission android:name="android.permission.INTERNET" />
-Original file line number
+Diff line change
@@ Expand Up / @@ -55,6 +55,7 @@ android { @@
                 proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
             }
         }
+        namespace 'com.example.android.uamp'
     }
     dependencies {
@@ Expand Down @@